Skip to content

Example should be renamed to include simpletest #31

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
kattni opened this issue Sep 30, 2019 · 2 comments
Closed

Example should be renamed to include simpletest #31

kattni opened this issue Sep 30, 2019 · 2 comments

Comments

@kattni
Copy link
Contributor

kattni commented Sep 30, 2019

Example busdevice_read_register_i2c.py could be renamed to busdevice_read_register_i2c_simpletest.py to match CircuitPython library standards.

The lines including this file name in the docs/examples.rst file must also be updated to reflect the name change, e.g.:

.. literalinclude:: ../examples/current_file_name.py
    :caption: examples/current_file_name.py
    :linenos:

would be updated to:

.. literalinclude:: ../examples/current_file_name_changed.py
    :caption: examples/current_file_name_changed.py
    :linenos:
@huyle1097
Copy link
Contributor

Hi @kattni
I have already made PR for this issue. Could you please review it and let me know if there is any problem? Thank you.

@tannewt
Copy link
Member

tannewt commented Oct 2, 2019

Fixed by #32. Thank you @huyle1097

@tannewt tannewt closed this as completed Oct 2, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants