From 5f81ba51b520834c30c4e640129b69b975cc0b4a Mon Sep 17 00:00:00 2001 From: Jeff Epler Date: Sun, 23 Aug 2020 11:01:51 -0500 Subject: [PATCH 1/4] remove bad-whitespace pylint directive --- adafruit_bluefruitspi.py | 2 -- 1 file changed, 2 deletions(-) diff --git a/adafruit_bluefruitspi.py b/adafruit_bluefruitspi.py index aa96d85..388bc6b 100644 --- a/adafruit_bluefruitspi.py +++ b/adafruit_bluefruitspi.py @@ -51,7 +51,6 @@ from adafruit_bus_device.spi_device import SPIDevice from micropython import const -# pylint: disable=bad-whitespace _MSG_COMMAND = const(0x10) # Command message _MSG_RESPONSE = const(0x20) # Response message _MSG_ALERT = const(0x40) # Alert message @@ -84,7 +83,6 @@ _PACKET_BUTTON_LEN = const(5) _PACKET_COLOR_LEN = const(6) -# pylint: enable=bad-whitespace class BluefruitSPI: From f179ce064578e411587140fad4ed9bf8f2794005 Mon Sep 17 00:00:00 2001 From: Jeff Epler Date: Sun, 23 Aug 2020 11:53:46 -0500 Subject: [PATCH 2/4] run black --- adafruit_bluefruitspi.py | 1 - 1 file changed, 1 deletion(-) diff --git a/adafruit_bluefruitspi.py b/adafruit_bluefruitspi.py index 388bc6b..6b742a7 100644 --- a/adafruit_bluefruitspi.py +++ b/adafruit_bluefruitspi.py @@ -84,7 +84,6 @@ _PACKET_COLOR_LEN = const(6) - class BluefruitSPI: """Helper for the Bluefruit LE SPI Friend""" From 6fe1c80520ecedc1b746b6b917894f3d86558da2 Mon Sep 17 00:00:00 2001 From: Jeff Epler Date: Mon, 24 Aug 2020 15:52:24 -0500 Subject: [PATCH 3/4] use raise ... from --- adafruit_bluefruitspi.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/adafruit_bluefruitspi.py b/adafruit_bluefruitspi.py index 6b742a7..2fe598f 100644 --- a/adafruit_bluefruitspi.py +++ b/adafruit_bluefruitspi.py @@ -247,7 +247,7 @@ def command(self, string): return rsp raise RuntimeError("Unknown response (id:{0})".format(hex(msgid))) except RuntimeError as error: - raise RuntimeError("AT command failure: " + repr(error)) + raise RuntimeError("AT command failure: " + repr(error)) from error def command_check_OK(self, command, delay=0.0): # pylint: disable=invalid-name """Send a fully formed bytestring AT command, and check From cd006d3e7c2974450a82f2f38c5a2b55ca52f270 Mon Sep 17 00:00:00 2001 From: Jeff Epler Date: Mon, 24 Aug 2020 16:01:05 -0500 Subject: [PATCH 4/4] address pylint wrong-import-order diagnostic --- examples/bluefruitspi_neocolorpicker.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/examples/bluefruitspi_neocolorpicker.py b/examples/bluefruitspi_neocolorpicker.py index b7db7e1..0d960a1 100644 --- a/examples/bluefruitspi_neocolorpicker.py +++ b/examples/bluefruitspi_neocolorpicker.py @@ -5,8 +5,8 @@ import busio import board from digitalio import DigitalInOut -from adafruit_bluefruitspi import BluefruitSPI import neopixel +from adafruit_bluefruitspi import BluefruitSPI ADVERT_NAME = b"BlinkaNeoLamp"