From aaab827d7ad09a52dd22ddd6b4bd34f81605f6dd Mon Sep 17 00:00:00 2001 From: foamyguy Date: Thu, 18 Nov 2021 16:21:29 -0600 Subject: [PATCH] remove usage of with context in bitmap_font.py and disable pylint check for now --- adafruit_bitmap_font/bitmap_font.py | 24 ++++++++++++------------ 1 file changed, 12 insertions(+), 12 deletions(-) diff --git a/adafruit_bitmap_font/bitmap_font.py b/adafruit_bitmap_font/bitmap_font.py index c7c1e15..e014311 100644 --- a/adafruit_bitmap_font/bitmap_font.py +++ b/adafruit_bitmap_font/bitmap_font.py @@ -28,24 +28,24 @@ def load_font(filename, bitmap=None): """Loads a font file. Returns None if unsupported.""" - # pylint: disable=import-outside-toplevel + # pylint: disable=import-outside-toplevel, consider-using-with if not bitmap: import displayio bitmap = displayio.Bitmap - with open(filename, "rb") as font_file: - first_four = font_file.read(4) - if filename.endswith("bdf") and first_four == b"STAR": - from . import bdf + font_file = open(filename, "rb") + first_four = font_file.read(4) + if filename.endswith("bdf") and first_four == b"STAR": + from . import bdf - return bdf.BDF(font_file, bitmap) - if filename.endswith("pcf") and first_four == b"\x01fcp": - from . import pcf + return bdf.BDF(font_file, bitmap) + if filename.endswith("pcf") and first_four == b"\x01fcp": + from . import pcf - return pcf.PCF(font_file, bitmap) - if filename.endswith("ttf") and first_four == b"\x00\x01\x00\x00": - from . import ttf + return pcf.PCF(font_file, bitmap) + if filename.endswith("ttf") and first_four == b"\x00\x01\x00\x00": + from . import ttf - return ttf.TTF(font_file, bitmap) + return ttf.TTF(font_file, bitmap) raise ValueError("Unknown magic number %r" % first_four)