-
Notifications
You must be signed in to change notification settings - Fork 24
Add option for configurable bounding box line search limit #55
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
This might have been the same issue that #48 was attempting to solve. I couldn't get the changes from that PR working and the person who made it never did respond. If you're interested in looking into this, it may be worth starting from the branch from that PR if it's still around. |
Ah, good catch! Sure, let me take a look! |
Ah, I think I see the problem - the PR branch only reads the next line when the current one it sees is a COMMENT. If there's anything between a COMMENT and a FONTBOUNDINGBOX parameter, it will never reach it. It can be fixed by making sure the next line is read in every loop iteration. Thanks again! |
resolved by #56 |
I recently had an issue where a BDF font file had a long license commented at the start, so this library would error out trying to initialize it. It was fixed by moving the license out of the file, but a configurable limit of lines to search for the bounding box parameter would prevent this issue. Not sure how either removing or increasing the limit would affect things like speed, however.
The text was updated successfully, but these errors were encountered: