From b7046e26a09fc715dbbdccde0666b45d113a22f7 Mon Sep 17 00:00:00 2001
From: Matt Land <matt-land@users.noreply.github.com>
Date: Tue, 3 May 2022 14:03:53 -0600
Subject: [PATCH 1/2] fix for #21, always create reference

---
 adafruit_bitmapsaver.py | 23 +++++++++++++----------
 1 file changed, 13 insertions(+), 10 deletions(-)

diff --git a/adafruit_bitmapsaver.py b/adafruit_bitmapsaver.py
index f0231e8..71b9f6b 100644
--- a/adafruit_bitmapsaver.py
+++ b/adafruit_bitmapsaver.py
@@ -1,4 +1,5 @@
 # SPDX-FileCopyrightText: 2019 Dave Astels for Adafruit Industries
+# SPDX-FileCopyrightText: 2022 Matt Land
 #
 # SPDX-License-Identifier: MIT
 
@@ -10,7 +11,7 @@
 Make a screenshot (the contents of a displayio.Display) and save in a BMP file.
 
 
-* Author(s): Dave Astels
+* Author(s): Dave Astels, Matt Land
 
 Implementation Notes
 --------------------
@@ -38,18 +39,18 @@
 
 def _write_bmp_header(output_file, filesize):
     output_file.write(bytes("BM", "ascii"))
-    output_file.write(struct.pack("<I", filesize))
+    output_file.write(struct.pack("<I", filesize))  # pylint: disable=no-member
     output_file.write(b"\00\x00")
     output_file.write(b"\00\x00")
-    output_file.write(struct.pack("<I", 54))
+    output_file.write(struct.pack("<I", 54))  # pylint: disable=no-member
 
 
 def _write_dib_header(output_file, width, height):
-    output_file.write(struct.pack("<I", 40))
-    output_file.write(struct.pack("<I", width))
-    output_file.write(struct.pack("<I", height))
-    output_file.write(struct.pack("<H", 1))
-    output_file.write(struct.pack("<H", 24))
+    output_file.write(struct.pack("<I", 40))  # pylint: disable=no-member
+    output_file.write(struct.pack("<I", width))  # pylint: disable=no-member
+    output_file.write(struct.pack("<I", height))  # pylint: disable=no-member
+    output_file.write(struct.pack("<H", 1))  # pylint: disable=no-member
+    output_file.write(struct.pack("<H", 24))  # pylint: disable=no-member
     for _ in range(24):
         output_file.write(b"\x00")
 
@@ -79,6 +80,7 @@ def _write_pixels(output_file, pixel_source, palette):
     saving_bitmap = isinstance(pixel_source, Bitmap)
     width, height = _rotated_height_and_width(pixel_source)
     row_buffer = bytearray(_bytes_per_row(width))
+    result_buffer = False
     for y in range(height, 0, -1):
         buffer_index = 0
         if saving_bitmap:
@@ -98,8 +100,9 @@ def _write_pixels(output_file, pixel_source, palette):
                     row_buffer[buffer_index] = b & 0xFF
                     buffer_index += 1
         output_file.write(row_buffer)
-        for i in range(width * 2):
-            result_buffer[i] = 0
+        if result_buffer:
+            for i in range(width * 2):
+                result_buffer[i] = 0
         gc.collect()
 
 

From f9cb0cd0341bf41b217b6663d72d3de0d737ea02 Mon Sep 17 00:00:00 2001
From: Matt Land <matt-land@users.noreply.github.com>
Date: Tue, 3 May 2022 14:49:50 -0600
Subject: [PATCH 2/2] remove the pylint comments #21

---
 adafruit_bitmapsaver.py | 14 +++++++-------
 1 file changed, 7 insertions(+), 7 deletions(-)

diff --git a/adafruit_bitmapsaver.py b/adafruit_bitmapsaver.py
index 71b9f6b..987cac8 100644
--- a/adafruit_bitmapsaver.py
+++ b/adafruit_bitmapsaver.py
@@ -39,18 +39,18 @@
 
 def _write_bmp_header(output_file, filesize):
     output_file.write(bytes("BM", "ascii"))
-    output_file.write(struct.pack("<I", filesize))  # pylint: disable=no-member
+    output_file.write(struct.pack("<I", filesize))
     output_file.write(b"\00\x00")
     output_file.write(b"\00\x00")
-    output_file.write(struct.pack("<I", 54))  # pylint: disable=no-member
+    output_file.write(struct.pack("<I", 54))
 
 
 def _write_dib_header(output_file, width, height):
-    output_file.write(struct.pack("<I", 40))  # pylint: disable=no-member
-    output_file.write(struct.pack("<I", width))  # pylint: disable=no-member
-    output_file.write(struct.pack("<I", height))  # pylint: disable=no-member
-    output_file.write(struct.pack("<H", 1))  # pylint: disable=no-member
-    output_file.write(struct.pack("<H", 24))  # pylint: disable=no-member
+    output_file.write(struct.pack("<I", 40))
+    output_file.write(struct.pack("<I", width))
+    output_file.write(struct.pack("<I", height))
+    output_file.write(struct.pack("<H", 1))
+    output_file.write(struct.pack("<H", 24))
     for _ in range(24):
         output_file.write(b"\x00")