Skip to content

UART mode only allows for 10Hz data reads #48

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
blakerutledge opened this issue Apr 29, 2020 · 4 comments · Fixed by #50
Closed

UART mode only allows for 10Hz data reads #48

blakerutledge opened this issue Apr 29, 2020 · 4 comments · Fixed by #50
Assignees

Comments

@blakerutledge
Copy link

If I modify the lib manually and decrease the sleep from 0.1 to 0.01 in the UART mode, I can read the data at 100Hz just fine.

Is there a reason these sleep values are so high and throttling the data?

@evaherrada
Copy link
Collaborator

@blakerutledge I'm not sure. Have you encountered any issues using it at 100Hz? If not, then make a PR and I can test (or I can make the PR if you'd prefer that)

@blakerutledge
Copy link
Author

Hi @dherrada! I am on a different machine for work now, I don't have the repo pulled for a PR, so you should handle. It was just those two lines where sleep in UART was 0.1seconds instead of 0.01.
I didn't have any issues! Curious to see your tests

@evaherrada
Copy link
Collaborator

@blakerutledge Ok, that's fine. Yeah, it didn't seem like there were too many changes, but I just wanted to make sure that changing the time.sleep was all you did. Thanks

@evaherrada evaherrada self-assigned this Jun 26, 2020
@evaherrada evaherrada linked a pull request Jul 10, 2020 that will close this issue
@evaherrada
Copy link
Collaborator

Fixed by #50, which improves stability and speed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants