Skip to content

Documentation #39

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
crablab opened this issue Jun 27, 2020 · 11 comments
Closed

Documentation #39

crablab opened this issue Jun 27, 2020 · 11 comments
Assignees

Comments

@crablab
Copy link

crablab commented Jun 27, 2020

Hey 👋

I note that this is missing Pydoc.

I'm happy to go through and add some if that would be useful? :)

@ladyada
Copy link
Member

ladyada commented Jun 28, 2020

@tannewt hihi you're the documentation expert, whatcha think? :)

@tannewt
Copy link
Member

tannewt commented Jun 29, 2020

@crablab What do you mean by Pydoc? It looks like the properties are documented: https://github.com/adafruit/Adafruit_CircuitPython_BME280/blob/master/adafruit_bme280.py#L295-L298

A PR to improve docs is always welcome!

@crablab
Copy link
Author

crablab commented Jun 29, 2020

Yeah, basically that but there are some places where it is missing and no explicit params or return values are supplied :)

eg.

def __init__(self, i2c, address=_BME280_ADDRESS):

If contributions to docs are okay, maybe I can take a look through and update some of the comments and then PR it? You can then yay or nay it 😊

@tannewt
Copy link
Member

tannewt commented Jun 30, 2020

@crablab Yup! All kinds of contributions are encouraged. Let me know if you need any help getting going. Most of the devs are available for questions on the Adafruit Discord too: https://adafru.it/discord

@evaherrada
Copy link
Collaborator

@crablab Hey, is this something you're still interested in doing? If not, that's totally fine

@crablab
Copy link
Author

crablab commented Aug 7, 2020

Hey! Sorry, I missed this 🙈 I'll have a look this weekend if that's okay?

@evaherrada
Copy link
Collaborator

@crablab No worries. This pr would be greatly appreciated, but don't feel obligated to work on it.

@crablab
Copy link
Author

crablab commented Aug 7, 2020

@dherrada For sure 😄 I'll update this at the weekend with what I have/haven't done to give you a steer! 😄

@jposada202020
Copy link
Contributor

@crablab Hello, would you like to work on this 😄 I can take a look during this weekend if you want

@crablab
Copy link
Author

crablab commented Apr 19, 2021

@jposada202020 Feel free! :)

@evaherrada
Copy link
Collaborator

closed by #46

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants