Fix test for Radio.send_bytes()

Author: tekktrik

adafruit_ble_radio.py

@@ -146,7 +146,7 @@ def send_bytes(self, message: bytes) -> None:
         # Concatenate the bytes that make up the advertised message.
         advertisement.msg = struct.pack("<BB", self._channel, self.uid) + message
 
-        self.uid = (self.uid + 1) % 255
+        self.uid = (self.uid + 1) % 256
         # Advertise (block) for AD_DURATION period of time.
         self.ble.start_advertising(advertisement)
         time.sleep(AD_DURATION)

tests/conftest.py

@@ -21,6 +21,7 @@
 # CircuitPython but not standard Python.
 MOCK_MODULES = [
     "adafruit_ble",
+    "adafruit_ble.advertising",
     "adafruit_ble.advertising.standard",
     "adafruit_ble.advertising.adafruit",
     "_bleio",

tests/test_adafruit_radio.py

@@ -11,6 +11,7 @@
 import time
 from unittest import mock
 import pytest
+from adafruit_ble.advertising import Advertisement
 import adafruit_ble_radio
 
 
@@ -97,7 +98,6 @@ def test_radio_send_bytes_too_long(radio_obj):
         radio_obj.send_bytes(msg)
 
 
-@pytest.mark.xfail(reason="Test should be checked and possibly updated")
 def test_radio_send_bytes(radio_obj):
     """
     Ensure the expected message is set on an instance of AdafruitRadio, and
@@ -108,9 +108,7 @@ def test_radio_send_bytes(radio_obj):
     with mock.patch("adafruit_ble_radio.time.sleep") as mock_sleep:
         radio_obj.send_bytes(msg)
         mock_sleep.assert_called_once_with(adafruit_ble_radio.AD_DURATION)
-    spy_advertisement = (
-        adafruit_ble_radio._RadioAdvertisement()  # pylint: disable=protected-access
-    )  # pylint: disable=protected-access
+    spy_advertisement = Advertisement
     chan = struct.pack("<B", radio_obj._channel)  # pylint: disable=protected-access
     uid = struct.pack("<B", 255)
     assert spy_advertisement.msg == chan + uid + msg