Skip to content

Missing sound level (exist in CPB) #13

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
dglaude opened this issue Jul 15, 2020 · 6 comments
Closed

Missing sound level (exist in CPB) #13

dglaude opened this issue Jul 15, 2020 · 6 comments
Labels
enhancement New feature or request

Comments

@dglaude
Copy link

dglaude commented Jul 15, 2020

As identified in the example code for CPB, the library would be better with sound_level support:
https://github.com/adafruit/Adafruit_CircuitPython_BLE_BroadcastNet/blob/master/examples/ble_broadcastnet_cpb.py

@evaherrada evaherrada added the enhancement New feature or request label Jul 17, 2020
@tekktrik
Copy link
Member

Hi @dglaude! I actually just submitted a PR to address this that's linked here if you want to check it out and potentially close the issue if it solves the problem!

@tekktrik
Copy link
Member

PR is merged! Please let me know if its sufficient to close the issue.

@dglaude
Copy link
Author

dglaude commented Dec 20, 2021

Thank you, I totally forgot about this.
Testing this would require a big effort for me: Setting up a Pi, adding blinka and that test code, then catching my CPB and testing.

But the code is pretty simple so it feel good.

Thank you very much.

@tekktrik
Copy link
Member

I don't have the hardware to test this so I'll so if anyone does (or I'll get some) so we can close this! Unless you feel it's sufficient without that. Otherwise I'll get on it eventually!

@tekktrik
Copy link
Member

Just tested, works like you'd expect! Tested using Raspberry Pi 2 Zero W with Blinka, a Circuit Playground Bluefruit at CircuitPython 7.1.0, and my Adafruit IO account. Picture for confirmation!

sound_level_confirmed

@tannewt
Copy link
Member

tannewt commented Jan 14, 2022

🎉

@tannewt tannewt closed this as completed Jan 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

4 participants