Skip to content

Implement __eq__ for Advertisement #85

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
kevinjwalters opened this issue May 28, 2020 · 2 comments
Closed

Implement __eq__ for Advertisement #85

kevinjwalters opened this issue May 28, 2020 · 2 comments
Labels
enhancement New feature or request

Comments

@kevinjwalters
Copy link

kevinjwalters commented May 28, 2020 •
edited
Loading

Implementing __eq__ method for Advertisement class will allow them to be compared in a useful way. Documention on how this works when some fields are not set would be useful.

Interim workaround is bytes(ad1) == bytes(as2)

First mentioned in comments in #79.
@evaherrada evaherrada added the enhancement New feature or request label Jun 17, 2020
@tekktrik tekktrik mentioned this issue Jan 16, 2022
Merged
@tekktrik
Copy link
Member

Resolved by PR #150!

@tannewt
Copy link
Member

tannewt commented Jan 19, 2022

Thank you!

@tannewt tannewt closed this as completed Jan 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@tannewt @kevinjwalters @evaherrada @tekktrik