Skip to content

Expose ADAFRUIT_COMPANY_ID and MANUFACTURING_DATA_ADT #83

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
kevinjwalters opened this issue May 14, 2020 · 4 comments
Closed

Expose ADAFRUIT_COMPANY_ID and MANUFACTURING_DATA_ADT #83

kevinjwalters opened this issue May 14, 2020 · 4 comments
Labels
enhancement New feature or request

Comments

@kevinjwalters
Copy link

kevinjwalters commented May 14, 2020

_MANUFACTURING_DATA_ADT and _ADAFRUIT_COMPANY_ID are defined in

_MANUFACTURING_DATA_ADT = const(0xFF)
_ADAFRUIT_COMPANY_ID = const(0x0822)
as 0xFF and 0x0822, respectively. The underscore prefix in conjunction with the use of const() (@dhalbert clarified this) makes them truly private and unusable from elsewhere.

These reference values would be useful to expose from somewhere in adafruit_ble library for other code which is creating packets, e.g.

These currently have their own local variables with these values.

@kevinjwalters
Copy link
Author

kevinjwalters commented May 27, 2020

I'm thinking of using sequence_number like the one used for AdafruitSensorMeasurement in https://github.com/adafruit/Adafruit_CircuitPython_BLE_BroadcastNet/blob/c6328d5c7edf8a99ff719c3b1798cb4111bab397/adafruit_ble_broadcastnet.py#L84-L85 - I have added a note to #79 (comment) about this too.

Does it make sense for its id number (0x0003) to be somewhere to allow developers to use it in custom Advertisement packets?

@evaherrada evaherrada added the enhancement New feature or request label Jun 17, 2020
@tekktrik
Copy link
Member

tekktrik commented Feb 2, 2022

Resolved by PR #154!

@dhalbert
Copy link
Collaborator

dhalbert commented Feb 2, 2022

In the PR, if you use one of these magic phrases, the issue will get linked and then closed when the PR is merged:
https://docs.github.com/en/issues/tracking-your-work-with-issues/linking-a-pull-request-to-an-issue#linking-a-pull-request-to-an-issue-using-a-keyword

@dhalbert dhalbert closed this as completed Feb 2, 2022
@tekktrik
Copy link
Member

tekktrik commented Feb 2, 2022

Oh I didn't know that, thank you!!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

4 participants