Skip to content

Commit 5a3f156

Browse files
authored
Merge pull request #51 from adafruit/dherrada-patch-2
Added pylint ignores so Actions will pass
2 parents 0b5f0bd + bdc8b44 commit 5a3f156

File tree

7 files changed

+15
-2
lines changed

7 files changed

+15
-2
lines changed

.travis.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -20,7 +20,7 @@ install:
2020
- pip install --force-reinstall "pylint<3"
2121

2222
script:
23-
- pylint --disable=too-few-public-methods adafruit_ble/**/*.py adafruit_ble/*.py
23+
- pylint adafruit_ble/**/*.py adafruit_ble/*.py
2424
- ([[ ! -d "examples" ]] || pylint --disable=missing-docstring,invalid-name,bad-whitespace
2525
examples/*.py)
2626
- circuitpython-build-bundles --filename_prefix adafruit-circuitpython-ble

adafruit_ble/advertising/__init__.py

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -85,6 +85,8 @@ def encode_data(data_dict, *, key_encoding="B"):
8585

8686
class AdvertisingDataField:
8787
"""Top level class for any descriptor classes that live in Advertisement or its subclasses."""
88+
# pylint: disable=too-few-public-methods,unnecessary-pass
89+
pass
8890

8991
class AdvertisingFlag:
9092
"""A single bit flag within an AdvertisingFlags object."""

adafruit_ble/attributes/__init__.py

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -63,6 +63,7 @@ class Attribute:
6363
6464
security_mode: authenticated data signing, without man-in-the-middle protection
6565
"""
66+
# pylint: disable=too-few-public-methods
6667
NO_ACCESS = _bleio.Attribute.NO_ACCESS
6768
OPEN = _bleio.Attribute.OPEN
6869
ENCRYPT_NO_MITM = _bleio.Attribute.ENCRYPT_NO_MITM

adafruit_ble/characteristics/int.py

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -60,30 +60,36 @@ def __set__(self, obj, value):
6060

6161
class Int8Characteristic(IntCharacteristic):
6262
"""Int8 number."""
63+
# pylint: disable=too-few-public-methods
6364
def __init__(self, *, min_value=-128, max_value=127, **kwargs):
6465
super().__init__("<b", min_value, max_value, **kwargs)
6566

6667
class Uint8Characteristic(IntCharacteristic):
6768
"""Uint8 number."""
69+
# pylint: disable=too-few-public-methods
6870
def __init__(self, *, min_value=0, max_value=0xff, **kwargs):
6971
super().__init__("<B", min_value, max_value, **kwargs)
7072

7173
class Int16Characteristic(IntCharacteristic):
7274
"""Int16 number."""
75+
# pylint: disable=too-few-public-methods
7376
def __init__(self, *, min_value=-32768, max_value=32767, **kwargs):
7477
super().__init__("<h", min_value, max_value, **kwargs)
7578

7679
class Uint16Characteristic(IntCharacteristic):
7780
"""Uint16 number."""
81+
# pylint: disable=too-few-public-methods
7882
def __init__(self, *, min_value=0, max_value=0xffff, **kwargs):
7983
super().__init__("<H", min_value, max_value, **kwargs)
8084

8185
class Int32Characteristic(IntCharacteristic):
8286
"""Int32 number."""
87+
# pylint: disable=too-few-public-methods
8388
def __init__(self, *, min_value=-2147483648, max_value=2147483647, **kwargs):
8489
super().__init__("<i", min_value, max_value, **kwargs)
8590

8691
class Uint32Characteristic(IntCharacteristic):
8792
"""Uint32 number."""
93+
# pylint: disable=too-few-public-methods
8894
def __init__(self, *, min_value=0, max_value=0xffffffff, **kwargs):
8995
super().__init__("<I", min_value, max_value, **kwargs)

adafruit_ble/services/midi.py

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -36,6 +36,7 @@
3636

3737
class MidiIOCharacteristic(Characteristic):
3838
"""Workhorse MIDI Characteristic that carries midi messages both directions. Unimplemented."""
39+
# pylint: disable=too-few-public-methods
3940
uuid = VendorUUID("7772E5DB-3868-4112-A1A9-F2669D106BF3")
4041
def __init__(self, **kwargs):
4142
super().__init__(properties=(Characteristic.NOTIFY |

adafruit_ble/services/standard/__init__.py

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -38,6 +38,7 @@
3838

3939
class AppearanceCharacteristic(StructCharacteristic):
4040
"""What type of device it is"""
41+
# pylint: disable=too-few-public-methods
4142
uuid = StandardUUID(0x2a01)
4243

4344
def __init__(self, **kwargs):

adafruit_ble/services/standard/hid.py

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -96,6 +96,7 @@ def send_report(self, report):
9696

9797
class ReportOut:
9898
"""A single HID report that receives HID data from a client."""
99+
# pylint: disable=too-few-public-methods
99100
uuid = StandardUUID(_REPORT_UUID_NUM)
100101
def __init__(self, service, report_id, usage_page, usage, *, max_length):
101102
self._characteristic = _bleio.Characteristic.add_to_service(
@@ -248,6 +249,7 @@ def _init_devices(self):
248249
i += size
249250

250251
def get_report_info(collection, reports):
252+
""" Gets info about hid reports """
251253
for main in collection["mains"]:
252254
if "type" in main:
253255
get_report_info(main, reports)
@@ -269,7 +271,7 @@ def get_report_info(collection, reports):
269271
reports = {}
270272
get_report_info(collection, reports)
271273
if len(reports) > 1:
272-
raise NotImplementedError("Only on report id per Application collection supported")
274+
raise NotImplementedError("Only one report id per Application collection supported")
273275

274276
report_id, report = list(reports.items())[0]
275277
output_size = report["output_size"]

0 commit comments

Comments
 (0)