Skip to content

Callbacks for subscribe and unsubscribe are not initialized #25

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
brentru opened this issue Aug 23, 2019 · 0 comments · Fixed by #27
Closed

Callbacks for subscribe and unsubscribe are not initialized #25

brentru opened this issue Aug 23, 2019 · 0 comments · Fixed by #27
Assignees
@brentru
Labels
bug Something isn't working

Comments

@brentru
Copy link
Member

brentru commented Aug 23, 2019

IO_MQTT's on_subscribe and on_subscribe are setup (https://github.com/adafruit/Adafruit_CircuitPython_AdafruitIO/blob/master/adafruit_io/adafruit_io.py#L81) but never run as they're not explicitly declared in the init (https://github.com/adafruit/Adafruit_CircuitPython_AdafruitIO/blob/master/adafruit_io/adafruit_io.py#L83) and do not have "handler" methods like connect/on_message/disconnect.

Two new methods need to be created within IO_MQTT which will handle the MiniMQTT client's on_subscribe and on_unsubscribe callback methods, named _on_subscribe_mqtt and _on_unsubscribe_mqtt
@brentru brentru added the bug Something isn't working label Aug 23, 2019
@brentru brentru self-assigned this Aug 23, 2019
@brentru brentru mentioned this issue Aug 28, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@brentru brentru

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Implement network callbacks for Feed Subscribe/Unsubscribe brentru/Adafruit_CircuitPython_AdafruitIO
1 participant
@brentru