Skip to content

No deinit() method on DigitalInOut class #4

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
chrisgilldc opened this issue Nov 22, 2021 · 1 comment
Open

No deinit() method on DigitalInOut class #4

chrisgilldc opened this issue Nov 22, 2021 · 1 comment

Comments

@chrisgilldc
Copy link

Good morning!

Trying to use HC-SR04 sensors via the AW9523 board. I'm trying to modify the hcsr04 library to accept the DigitalInOut objects from the AW9523 instance, but they don't have a deinit() method. This is counter to the notes in the AW9523 library, which say "this interface is exactly the same as the digitalio.DigitalInOut class". It's not, since at least one method is missing.

So either this library needs to be brought in line with the main digitalio.DigitalInOut class, or the notes should be updated to reflect that they're substantially the same but not 1:1 the same. I've love if it were the first, because then that makes this a drop-in replacement.

Thanks.

@ladyada
Copy link
Member

ladyada commented Nov 22, 2021

hiya, fastest way to get it added is if you're able to add that function and submit a PR. especially since you're testing in a particular context. deiniting should just set the pin to be an input :)

@tekktrik tekktrik mentioned this issue Dec 3, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants