From d907d45439db3e91eabacecc16cf4659442c35cd Mon Sep 17 00:00:00 2001 From: dertobias <47625025+dertobias@users.noreply.github.com> Date: Sat, 4 Nov 2023 22:49:54 +0100 Subject: [PATCH 1/2] RuntimeError not needed RuntimeError Exception prohibits code to proceed. Tested with (apds)GY-9960 board. --- adafruit_apds9960/apds9960.py | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/adafruit_apds9960/apds9960.py b/adafruit_apds9960/apds9960.py index 2dc4733..a559229 100644 --- a/adafruit_apds9960/apds9960.py +++ b/adafruit_apds9960/apds9960.py @@ -183,8 +183,8 @@ def __init__( self.i2c_device = I2CDevice(i2c, _APDS9960_I2C_ADDRESS) - if self._read8(_APDS9960_ID) != _DEVICE_ID: - raise RuntimeError() + #if self._read8(_APDS9960_ID) != _DEVICE_ID: + # raise RuntimeError() if reset: # Disable prox, gesture, and color engines From 88d730cfaef1bbbd132667c52a59bc0bd126ebcf Mon Sep 17 00:00:00 2001 From: dertobias <47625025+dertobias@users.noreply.github.com> Date: Tue, 14 Nov 2023 19:32:13 +0100 Subject: [PATCH 2/2] Update apds9960.py Changed IDs to tuple and added new chip ID --- adafruit_apds9960/apds9960.py | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/adafruit_apds9960/apds9960.py b/adafruit_apds9960/apds9960.py index a559229..b41d899 100644 --- a/adafruit_apds9960/apds9960.py +++ b/adafruit_apds9960/apds9960.py @@ -51,7 +51,7 @@ # Only one address is possible for the APDS9960, no alternates are available _APDS9960_I2C_ADDRESS = const(0x39) -_DEVICE_ID = const(0xAB) +_DEVICE_IDS = (const(0xAB), const(0xA8)) # APDS9960_RAM = const(0x00) _APDS9960_ENABLE = const(0x80) @@ -183,8 +183,8 @@ def __init__( self.i2c_device = I2CDevice(i2c, _APDS9960_I2C_ADDRESS) - #if self._read8(_APDS9960_ID) != _DEVICE_ID: - # raise RuntimeError() + if self._read8(_APDS9960_ID) not in _DEVICE_IDS: + raise RuntimeError() if reset: # Disable prox, gesture, and color engines