Skip to content

no method for setting pgain/ggain #41

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
bablokb opened this issue Feb 26, 2022 · 2 comments · Fixed by #42
Closed

no method for setting pgain/ggain #41

bablokb opened this issue Feb 26, 2022 · 2 comments · Fixed by #42

Comments

@bablokb
Copy link

bablokb commented Feb 26, 2022

I know that the policy for this lib is to not expose all registers to keep the footprint small. But I think it really needs methods for setting the proximity-gain (PGAIN) and gesture-gain (GGAIN). The default is 1x and 4x respectively. With this setting, proximity detection kicks in at a distance below an inch (at least for my sensor), which makes the driver almost useless.

The lib already has a setter/getter for the color-gain (AGAIN), and I would provide a patch with similar methods for the PGAIN/GGAIN settings if you also think this is a useful addition.

@ladyada
Copy link
Member

ladyada commented Feb 26, 2022

Sure, please submit a PR :)

@bablokb
Copy link
Author

bablokb commented Mar 3, 2022

I created pull-request #42

@tekktrik tekktrik linked a pull request Mar 3, 2022 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants