Skip to content

Error in order of statements in custom_frequency.ino example #62

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
karlsgodt opened this issue May 20, 2021 · 3 comments
Closed

Error in order of statements in custom_frequency.ino example #62

karlsgodt opened this issue May 20, 2021 · 3 comments

Comments

@karlsgodt
Copy link

  • Arduino board: Custom ATMEGA2560 board
  • Arduino IDE version 1.8.12
  • List the steps to reproduce the problem below (if possible attach a sketch or
    copy the sketch code in too): LIST REPRO STEPS BELOW

In the Custom Frequency Example, custom_frequency.ino the two statements in the setup() function are out of order:

Wire.setClock(1700000); // set frequency to 1.7mhz

...needs to come AFTER

mcp.begin(&Wire); // use default address 0

...or else the new clock frequency does not take effect.

@ladyada
Copy link
Member

ladyada commented May 20, 2021

ok! please submit a PR for the fix!

@karlsgodt
Copy link
Author

I need write access to the repo, yes?

@caternuson
Copy link
Contributor

@karlsgodt No, you'd make a pull request from your own copy (fork) on this repo. But I think #63 will also fix this eventually.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants