Skip to content

Commit 70fa320

Browse files
Merge pull request #431 from akv-platform/allow-json-comments
Allow json comments
2 parents 7ed547c + b5ebe9e commit 70fa320

File tree

6 files changed

+1539
-7
lines changed

6 files changed

+1539
-7
lines changed

.github/workflows/e2e-tests.yml

Lines changed: 25 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -229,6 +229,31 @@ jobs:
229229
shell: pwsh
230230
run: __tests__/verify-dotnet.ps1 -Patterns "^2.2"
231231

232+
test-global-json-with-comments:
233+
runs-on: ${{ matrix.operating-system }}
234+
strategy:
235+
fail-fast: false
236+
matrix:
237+
operating-system: [ubuntu-latest, windows-latest, macOS-latest]
238+
steps:
239+
- name: Checkout
240+
uses: actions/checkout@v3
241+
- name: Clear toolcache
242+
shell: pwsh
243+
run: __tests__/clear-toolcache.ps1 ${{ runner.os }}
244+
- name: Write global.json
245+
shell: bash
246+
run: |
247+
mkdir subdirectory
248+
echo '/* should support comments */ {"sdk":{"version": "2.2.207","rollForward": "latestFeature"}} // should support comments' > ./subdirectory/global.json
249+
- name: Setup dotnet
250+
uses: ./
251+
with:
252+
global-json-file: ./subdirectory/global.json
253+
- name: Verify dotnet
254+
shell: pwsh
255+
run: __tests__/verify-dotnet.ps1 -Patterns "^2.2"
256+
232257
test-setup-with-dotnet-quality:
233258
runs-on: ${{ matrix.operating-system }}
234259
strategy:

.licenses/npm/json5.dep.yml

Lines changed: 36 additions & 0 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

0 commit comments

Comments
 (0)