Skip to content

deprecated warning in deps #49

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
Mister-Hope opened this issue Dec 20, 2022 · 5 comments · Fixed by #65
Closed

deprecated warning in deps #49

Mister-Hope opened this issue Dec 20, 2022 · 5 comments · Fixed by #65
Labels
question Further information is requested

Comments

@Mister-Hope
Copy link 

[email protected]: This module is not used anymore, and has been replaced by @npmcli/package-json

I want to avoid deprecation warning from standard-version to this one, but your package is still showing some warnings, could you use the replaced one?
@Mister-Hope Mister-Hope added the question Further information is requested label Dec 20, 2022
@TimothyJones
Copy link
Member

Sure thing! I’ll take a look

@TimothyJones
Copy link
Member

This is a little fiddly, as the new one is not a drop in replacement (the API for @npmcli/package-json is now async, whereas the previous one was synchronous - along with a couple of other changes).

I'll be able to set aside some time in early jan for this. If you'd like a fix sooner, PRs are very welcome - I can easily review and release.

@Merfoo Merfoo mentioned this issue Apr 5, 2023
Merged
@Merfoo
Copy link

Merfoo commented Apr 5, 2023

Hi @TimothyJones, I've created a PR to address this issue.
Let me know if you think the PR is a suitable solution to the issue.

@TimothyJones
Copy link
Member

Love it! Thank you so much.

I added a comment. if you could sort out the license, then I'll get it merged and released asap.

@TimothyJones
Copy link
Member

Released in 11.2.1, thanks again.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
question Further information is requested
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

chore(dep): add stringify-package to project source Merfoo/commit-and-tag-version
3 participants
@TimothyJones @Merfoo @Mister-Hope