Skip to content

Commit 87fe7de

Browse files
committed
coverage: Rename some FFI fields from span to cov_span
This will avoid confusion with actual `Span` spans.
1 parent 619a272 commit 87fe7de

File tree

2 files changed

+10
-9
lines changed

2 files changed

+10
-9
lines changed

compiler/rustc_codegen_llvm/src/coverageinfo/ffi.rs

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -156,15 +156,15 @@ impl CoverageSpan {
156156
#[derive(Clone, Debug)]
157157
#[repr(C)]
158158
pub(crate) struct CodeRegion {
159-
pub(crate) span: CoverageSpan,
159+
pub(crate) cov_span: CoverageSpan,
160160
pub(crate) counter: Counter,
161161
}
162162

163163
/// Must match the layout of `LLVMRustCoverageBranchRegion`.
164164
#[derive(Clone, Debug)]
165165
#[repr(C)]
166166
pub(crate) struct BranchRegion {
167-
pub(crate) span: CoverageSpan,
167+
pub(crate) cov_span: CoverageSpan,
168168
pub(crate) true_counter: Counter,
169169
pub(crate) false_counter: Counter,
170170
}
@@ -173,7 +173,7 @@ pub(crate) struct BranchRegion {
173173
#[derive(Clone, Debug)]
174174
#[repr(C)]
175175
pub(crate) struct MCDCBranchRegion {
176-
pub(crate) span: CoverageSpan,
176+
pub(crate) cov_span: CoverageSpan,
177177
pub(crate) true_counter: Counter,
178178
pub(crate) false_counter: Counter,
179179
pub(crate) mcdc_branch_params: mcdc::BranchParameters,
@@ -183,6 +183,6 @@ pub(crate) struct MCDCBranchRegion {
183183
#[derive(Clone, Debug)]
184184
#[repr(C)]
185185
pub(crate) struct MCDCDecisionRegion {
186-
pub(crate) span: CoverageSpan,
186+
pub(crate) cov_span: CoverageSpan,
187187
pub(crate) mcdc_decision_params: mcdc::DecisionParameters,
188188
}

compiler/rustc_codegen_llvm/src/coverageinfo/mapgen.rs

Lines changed: 6 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -271,29 +271,30 @@ fn encode_mappings_for_function(
271271
// form suitable for FFI.
272272
for (mapping_kind, region) in counter_regions {
273273
debug!("Adding counter {mapping_kind:?} to map for {region:?}");
274-
let span = ffi::CoverageSpan::from_source_region(local_file_id, region);
274+
let cov_span = ffi::CoverageSpan::from_source_region(local_file_id, region);
275275
match mapping_kind {
276276
MappingKind::Code(term) => {
277-
code_regions.push(ffi::CodeRegion { span, counter: ffi::Counter::from_term(term) });
277+
code_regions
278+
.push(ffi::CodeRegion { cov_span, counter: ffi::Counter::from_term(term) });
278279
}
279280
MappingKind::Branch { true_term, false_term } => {
280281
branch_regions.push(ffi::BranchRegion {
281-
span,
282+
cov_span,
282283
true_counter: ffi::Counter::from_term(true_term),
283284
false_counter: ffi::Counter::from_term(false_term),
284285
});
285286
}
286287
MappingKind::MCDCBranch { true_term, false_term, mcdc_params } => {
287288
mcdc_branch_regions.push(ffi::MCDCBranchRegion {
288-
span,
289+
cov_span,
289290
true_counter: ffi::Counter::from_term(true_term),
290291
false_counter: ffi::Counter::from_term(false_term),
291292
mcdc_branch_params: ffi::mcdc::BranchParameters::from(mcdc_params),
292293
});
293294
}
294295
MappingKind::MCDCDecision(mcdc_decision_params) => {
295296
mcdc_decision_regions.push(ffi::MCDCDecisionRegion {
296-
span,
297+
cov_span,
297298
mcdc_decision_params: ffi::mcdc::DecisionParameters::from(mcdc_decision_params),
298299
});
299300
}

0 commit comments

Comments
 (0)