Skip to content

Suggestions for Ch 1 - Pandas intro #37

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
21 of 24 tasks
joelostblom opened this issue Aug 24, 2022 · 5 comments · Fixed by #48
Closed
21 of 24 tasks

Suggestions for Ch 1 - Pandas intro #37

joelostblom opened this issue Aug 24, 2022 · 5 comments · Fixed by #48

Comments

@joelostblom
Copy link
Contributor

joelostblom commented Aug 24, 2022

These are all suggestions, some might seem more harshly written, but that is just to be succinct and write quickly.

  • "Python and THE pandas" -> "Python and pandas"
  • Elaborate on pd import alias
  • Fig 2 is the R-version and the font is too small
  • Remove print statements under "Naming things"
  • Variable names can't use .
  • Switching to - instead of + is a more natural example for non-working var names.
  • Data frames (>60 rows) are not printed just as the first few rows in Python, it also include the last few rows and a ... that could use an explanation. And the number of rows and columns are printed at the bottom, not top.
  • Mention that single and double quotes are exchangeable to avoid confusion
  • The corresponding figures to 1.3 and up, in the R book are all missing in python.
  • Should we explain .query or []? The former has some advantages in clearer chaining syntax, but is not as well documented.
  • "greatest to least" -> "largest to smallest value"
  • Introduce the contrast of df.method versus pd.function. Dataframes have the most important functions built-in which is great for finding help and what you're looking for.
  • "introduce tidy data in Chapter Cleaning" -> "introduce tidy data in THE Chapter Cleaning"
  • "A bar plot is a chart where the heights of the bars" -> "A bar plot is a chart where the LENGTHS of the bars".
  • R - Isn't stat == identify the default for bar? Or is that column? And does it even matter with one value?
  • The Python explanation for how expressions can continue on another line is wrong. It is not the ., it is the open paren (which is preferred over "")
  • Better explanation of alt.X and alt.Y, take from 531 lecture notes.
  • I think the organization of the bars could benefit from having the largest bar closest to the axis.
  • Visualization syntax in "putting it all together" is off
  • Discuss the most common ways of getting help in JupyterLab, shift+tab and the contextual explorer. ? also works in place of help in ipython, I don't think printing the docstring is worth teaching.
  • Exercises mention "R and the tidyverse"
  • Recommend nlargest/nsmallest over sorting and slicing #35
  • Explain filtering of rows and selection of columns in a more Pandas-centric way #34
  • Standardize syntax for visualizations #29
@trevorcampbell
Copy link
Contributor

@joelostblom "Better explanation of alt.X and alt.Y, take from 531 lecture notes."

can you paste that here pls?

@trevorcampbell
Copy link
Contributor

Actually, just file a new issue for it -- what is there right now in Chapter 1 is good enough for running the course. We can (and should) make enhancements later.

@trevorcampbell
Copy link
Contributor

The separate issue threads I think again are "nice to have"s, but not mandatory for the first run of the course, so checking them all off

@joelostblom
Copy link
Contributor Author

Yes I can open a new issue for that! I think it's useful if we open new issues or leave unchecked all the things we don't implement just so that we can keep track of it and decide if we want it later.

@trevorcampbell
Copy link
Contributor

That's what I've been doing -- "checked off" means either handled in the upcoming PR or spun out into its own issue for later.

@trevorcampbell trevorcampbell linked a pull request Dec 19, 2022 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants