Skip to content

Inconsistent axis label code style #224

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
trevorcampbell opened this issue Aug 31, 2023 · 1 comment · Fixed by #317
Closed

Inconsistent axis label code style #224

trevorcampbell opened this issue Aug 31, 2023 · 1 comment · Fixed by #317
Labels
enhancement New feature or request low-priority

Comments

@trevorcampbell
Copy link
Contributor

trevorcampbell commented Aug 31, 2023

I've noticed that the code isn't consistent between alt.Y('blah').title('blah') and alt.Y('blah', title='blah') -- I noticed this in inference but it could be more pervasive. I think the newer style is alt.Y('blah').title('blah'), so we should switch everything over to that.

I think all the instances of that inconsistency are in remove-cell tagged cells, so not the end of the world, but it would be good to ensure that code is consistent throughout, even in hidden cells

@trevorcampbell trevorcampbell added enhancement New feature or request low-priority labels Aug 31, 2023
@joelostblom
Copy link
Contributor

Yup I almost only fixed what was visible in the book since the other syntax is still valid and it made the important changes stand out more. I agree it would be nice to have it the same everywhere, especially when grepping for something, but agree that this is low prio.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request low-priority
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants