Merge pull request #21 from angular/master

Update upstream

Author: GulajavaMinistudio

.travis.yml

@@ -5,33 +5,23 @@ node_js:
 
 addons:
   chrome: stable
-  apt:
-    sources:
-      - ubuntu-toolchain-r-test
-    packages:
-      - g++-4.8
 
-cache: npm
+cache:
+  yarn: true
+  directories:
+    - node_modules
+    - "$HOME/.npm"
+    - "$HOME/.cache"
 
-env:
-  - CXX=g++-4.8
+branches:
+  only:
+    - master # otherwise pull requests get built twice
 
 install:
-  # ditched yarn, since it was acting up and giving old versions of tsc
-  - npm install
-
-before_script:
-  - export DISPLAY=:99.0
-  - sh -e /etc/init.d/xvfb start
+  - yarn install
 
 script:
-  - npm run build
-  - ./node_modules/.bin/karma start --single-run --browsers Firefox --reporters mocha
+  - yarn run build
+  - ./node_modules/.bin/karma start --single-run --browsers ChromeHeadlessTravis --reporters mocha
   # Run integration test to make sure our typings are correct for user-land.
   - node tools/run-typings-test.js
-
-notifications:
-  webhooks:
-    on_success: always  # options: [always|never|change] default: always
-    on_failure: always  # options: [always|never|change] default: always
-    on_start: false     # default: false

PULL_REQUEST_TEMPLATE.md

@@ -25,7 +25,7 @@ before sending PRs. We cannot accept code without this.
    - Issue number for this PR: #nnn (required)
    - Docs included?: (yes/no; required for all API/functional changes) 
    - Test units included?: (yes/no; required) 
-   - In a clean directory, `npm install`, `npm run build`, and `npm test` run successfully? (yes/no; required)
+   - In a clean directory, `yarn install`, `yarn test` run successfully? (yes/no; required)
 
 ### Description
 

karma.conf.js

@@ -41,8 +41,14 @@ module.exports = function(config) {
     logLevel: config.LOG_INFO,
     autoWatch: true,
     reporters: ['mocha'],
-    browsers: ['Firefox'],
-    singleRun: false
+    browsers: ['ChromeHeadless'],
+    singleRun: false,
+    customLaunchers: {
+      ChromeHeadlessTravis: {
+        base: 'ChromeHeadless',
+        flags: ['--no-sandbox']
+      }
+    },
   })
 };
 

src/firestore/document/document.ts

@@ -89,9 +89,9 @@ export class AngularFirestoreDocument<T> {
   /**
    * Listen to unwrapped snapshot updates from the document.
    */
-  valueChanges(): Observable<T> {
+  valueChanges(): Observable<T|null> {
     return this.snapshotChanges().map(action => {
-      return (action.payload.exists ? action.payload.data() : null) as T;
+      return action.payload.exists ? action.payload.data() as T : null;
     });
   }
 }

tools/run-typings-test.js

@@ -35,7 +35,7 @@ ncp(pathToTestSrcFolder, pathToTestFolder, () => {
     .replace('{{TYPESCRIPT_VERSION}}', rootPackage.devDependencies.typescript)
     .replace(/\{\{ANGULAR_VERSION\}\}/g, rootPackage.dependencies['@angular/core']));
 
-    spawnIt('npm', ['install'])
+    spawnIt('yarn', ['install'])
       .then(_ => spawnIt(`${pathToTestFolder}/node_modules/.bin/tsc`, ['--version']))
       .then(_ => new Promise((res, rej) => {
         child_process.exec(`${pathToTestFolder}/node_modules/.bin/tsc --diagnostics -p ${pathToTestFolder}/tsconfig-test.json`, (err, stdout, stderr) => {