Translate between win32 and posix paths in errorPusher

Author: guncha

dist/main/atom/utils/fs.js

@@ -2,12 +2,14 @@
  * Wraps fs and path into a nice "consistentPath" API
  */
 "use strict";
-/** we work with "/" for all paths (so does the typescript language service) */
 function consistentPath(filePath) {
     return filePath.split('\\').join('/');
 }
 exports.consistentPath = consistentPath;
 const path = require("path");
+// Atom uses system dependent path separators while Typescript uses /. Unfortunately, we
+// needs this to make sure things like lint errors work.
+exports.systemPath = path.sep === "\\" ? filePath => filePath.replace(/\//g, "\\") : filePath => filePath;
 /**
  * Resolves to to an absolute path.
  * @param from,to,to,to...

dist/main/errorPusher.js

@@ -9,11 +9,12 @@ class ErrorPusher {
             const errors = [];
             for (const fileErrors of this.errors.values()) {
                 for (const [filePath, diagnostics] of fileErrors) {
+                    const _filePath = utils_1.systemPath(filePath);
                     for (const diagnostic of diagnostics) {
                         errors.push({
                             type: "Error",
                             text: diagnostic.text,
-                            filePath: filePath,
+                            filePath: _filePath,
                             range: diagnostic.start ? utils_1.locationsToRange(diagnostic.start, diagnostic.end) : undefined
                         });
                     }

lib/main/atom/utils/fs.ts

@@ -2,13 +2,16 @@
  * Wraps fs and path into a nice "consistentPath" API
  */
 
-/** we work with "/" for all paths (so does the typescript language service) */
 export function consistentPath(filePath: string): string {
-    return filePath.split('\\').join('/');
+  return filePath.split('\\').join('/');
 }
 
 import * as path from "path";
 
+// Atom uses system dependent path separators while Typescript uses /. Unfortunately, we
+// needs this to make sure things like lint errors work.
+export const systemPath: (filePath: string) => string = path.sep === "\\" ? filePath => filePath.replace(/\//g, "\\") : filePath => filePath
+
 /**
  * Resolves to to an absolute path.
  * @param from,to,to,to...

lib/main/errorPusher.ts

@@ -1,7 +1,7 @@
 import {debounce} from "lodash"
 import {Diagnostic} from "typescript/lib/protocol"
 import {Linter, LinterMessage} from "../typings/linter"
-import {locationsToRange} from "./atom/utils"
+import {locationsToRange, systemPath} from "./atom/utils"
 
 /** Class that collects errors from all of the clients and pushes them to the Linter service */
 export class ErrorPusher {
@@ -38,11 +38,12 @@ export class ErrorPusher {
 
     for (const fileErrors of this.errors.values()) {
       for (const [filePath, diagnostics] of fileErrors) {
+        const _filePath = systemPath(filePath)
         for (const diagnostic of diagnostics) {
           errors.push({
             type: "Error",
             text: diagnostic.text,
-            filePath: filePath,
+            filePath: _filePath,
             range: diagnostic.start ? locationsToRange(diagnostic.start, diagnostic.end) : undefined
           })
         }