Update typescript and enable strict mode

Author: guncha

dist/client/findServer.js

@@ -51,8 +51,8 @@ function attach(editorView, editor) {
         clearExprTypeTimeout();
         exprTypeTimeout = setTimeout(() => showExpressionType(e), 100);
     });
-    subscriber.subscribe(scroll, 'mouseout', (e) => clearExprTypeTimeout());
-    subscriber.subscribe(scroll, 'keydown', (e) => clearExprTypeTimeout());
+    subscriber.subscribe(scroll, 'mouseout', () => clearExprTypeTimeout());
+    subscriber.subscribe(scroll, 'keydown', () => clearExprTypeTimeout());
     // Setup for clearing
     editor.onDidDestroy(() => deactivate());
     function showExpressionType(e) {

dist/main/atom/tooltipManager.js

@@ -3,6 +3,27 @@ Object.defineProperty(exports, "__esModule", { value: true });
 const view = require("./view");
 var $ = view.$;
 class LineMessageView extends view.View {
+    constructor() {
+        super(...arguments);
+        this.goToLine = () => {
+            this.options.goToLine(this.options.file, this.options.line, this.options.col);
+        };
+        this.getSummary = () => {
+            var pos = this.options.line.toString();
+            if (this.options.file !== undefined) {
+                pos += ', ' + this.options.file;
+            }
+            return {
+                summary: pos + ' ' + this.options.message,
+                rawSummary: true,
+                handler: (element) => {
+                    $(element)
+                        .css('cursor', 'pointer')
+                        .click(this.goToLine);
+                }
+            };
+        };
+    }
     static content() {
         return this.div({
             class: 'line-message'
@@ -39,23 +60,5 @@ class LineMessageView extends view.View {
             this.code.remove();
         }
     }
-    goToLine() {
-        this.options.goToLine(this.options.file, this.options.line, this.options.col);
-    }
-    getSummary() {
-        var pos = this.options.line.toString();
-        if (this.options.file !== undefined) {
-            pos += ', ' + this.options.file;
-        }
-        return {
-            summary: pos + ' ' + this.options.message,
-            rawSummary: true,
-            handler: function (element) {
-                $(element)
-                    .css('cursor', 'pointer')
-                    .click(this.goToLine.bind(this));
-            }.bind(this)
-        };
-    }
 }
 exports.LineMessageView = LineMessageView;

dist/main/atom/views/lineMessageView.js

@@ -27,8 +27,8 @@ export class TypescriptServiceClient {
   callbacks: {
     [seq: number]: {
       name: string
-      reject(res)
-      resolve(res)
+      reject(err: Error): void
+      resolve(res: protocol.Response): void
       started: number
     }
   } = {}
@@ -47,7 +47,7 @@ export class TypescriptServiceClient {
   readonly tsServerArgs = []
   readonly version: string
 
-  constructor(tsServerPath: string, version) {
+  constructor(tsServerPath: string, version: string) {
     this.tsServerPath = tsServerPath
     this.version = version
   }
@@ -110,7 +110,7 @@ export class TypescriptServiceClient {
     return this.execute("saveto", args)
   }
 
-  private async execute(command: string, args) {
+  private async execute(command: string, args: any) {
     if (!this.serverPromise) {
       throw new Error("Server is not running")
     }
@@ -161,10 +161,10 @@ export class TypescriptServiceClient {
     }
   }
 
-  private sendRequest(cp: ChildProcess, command: string, args, expectResponse: true): Promise<protocol.Response>
-  private sendRequest(cp: ChildProcess, command: string, args, expectResponse: false): undefined
-  private sendRequest(cp: ChildProcess, command: string, args, expectResponse: boolean): Promise<protocol.Response> | undefined
-  private sendRequest(cp: ChildProcess, command: string, args, expectResponse: boolean): Promise<protocol.Response> | undefined {
+  private sendRequest(cp: ChildProcess, command: string, args: any, expectResponse: true): Promise<protocol.Response>
+  private sendRequest(cp: ChildProcess, command: string, args: any, expectResponse: false): undefined
+  private sendRequest(cp: ChildProcess, command: string, args: any, expectResponse: boolean): Promise<protocol.Response> | undefined
+  private sendRequest(cp: ChildProcess, command: string, args: any, expectResponse: boolean): Promise<protocol.Response> | undefined {
 
     const req = {
       seq: this.seq++,
@@ -248,7 +248,7 @@ class MessageStream extends Transform {
     super({objectMode: true})
   }
 
-  _transform(line, encoding, callback) {
+  _transform(line: string, encoding: string, callback: Function) {
     if (this.lineCount % 2 === 0) {
       this.push(JSON.parse(line))
     }

lib/client/client.ts

@@ -8,7 +8,10 @@ import * as Atom from "atom"
 import * as fuzzaldrin from "fuzzaldrin"
 
 const importPathScopes = ["meta.import", "meta.import-equals", "triple-slash-directive"]
-type SuggestionWithDetails = Suggestion & {details?}
+
+type SuggestionWithDetails = Suggestion & {
+  details?: protocol.CompletionEntryDetails
+}
 
 type Options = {
   getTypescriptBuffer: (filePath: string) => Promise<{
@@ -190,7 +193,7 @@ function getLocationQuery(opts: RequestOptions): FileLocationQuery {
 function getLastNonWhitespaceChar(buffer: TextBuffer.ITextBuffer, pos: TextBuffer.IPoint): string | undefined {
   let lastChar: string | undefined = undefined
   const range = new Atom.Range([0,0], pos)
-  buffer.backwardsScanInRange(/\S/, range, ({matchText, stop}) => {
+  buffer.backwardsScanInRange(/\S/, range, ({matchText, stop}: {matchText: string, stop: () => void}) => {
       lastChar = matchText
       stop()
     })

lib/client/findServer.ts

@@ -47,7 +47,7 @@ commands.set("typescript:build", deps => {
   }
 })
 
-function _finally<T>(promise: Promise<T>, callback: (result) => any): Promise<T> {
+function _finally<T>(promise: Promise<T>, callback: (result: T) => any): Promise<T> {
   promise.then(callback, callback)
   return promise
 }

lib/main/atom/autoCompleteProvider.ts

@@ -22,7 +22,7 @@ commands.set("typescript:check-all-files", deps => {
     // the files set is going to receive a a diagnostic event (typically some d.ts files). To counter
     // that, we cancel the listener and close the progress bar after no diagnostics have been received
     // for some amount of time.
-    let cancelTimeout
+    let cancelTimeout: any
 
     const unregister = client.on("syntaxDiag", evt => {
       clearTimeout(cancelTimeout)

lib/main/atom/commands/build.ts

@@ -4,7 +4,7 @@ import {StatusPanel} from "../../atom/components/statusPanel"
 import {TypescriptBuffer} from "../../typescriptBuffer"
 
 export interface Dependencies {
-  clearErrors()
+  clearErrors(): void
   getTypescriptBuffer(filePath: string): Promise<{buffer: TypescriptBuffer, isOpen: boolean}>
   getClient(filePath: string): Promise<TypescriptServiceClient>
   renameView: RenameView

lib/main/atom/commands/checkAllFiles.ts

@@ -2,8 +2,8 @@
 // http://www.html5rocks.com/en/tutorials/webcomponents/customelements/ (look at lifecycle callback methods)
 
 export class TsView extends HTMLElement {
-    editorElement;
-    editor;
+    editorElement: HTMLElement
+    editor: AtomCore.IEditor
     createdCallback() {
         var preview = this.innerText;
         this.innerText = "";

lib/main/atom/commands/registry.ts

@@ -45,7 +45,7 @@ export function attach(editorView: JQuery, editor: AtomCore.IEditor) {
     // to debounce mousemove event's firing for some reason on some machines
     var lastExprTypeBufferPt: any;
 
-    subscriber.subscribe(scroll, 'mousemove', (e) => {
+    subscriber.subscribe(scroll, 'mousemove', (e: MouseEvent) => {
         var pixelPt = pixelPositionFromMouseEvent(editorView, e)
         var screenPt = editor.element.screenPositionForPixelPosition(pixelPt)
         var bufferPt = editor.bufferPositionForScreenPosition(screenPt)
@@ -57,8 +57,8 @@ export function attach(editorView: JQuery, editor: AtomCore.IEditor) {
         clearExprTypeTimeout();
         exprTypeTimeout = setTimeout(() => showExpressionType(e), 100);
     });
-    subscriber.subscribe(scroll, 'mouseout', (e) => clearExprTypeTimeout());
-    subscriber.subscribe(scroll, 'keydown', (e) => clearExprTypeTimeout());
+    subscriber.subscribe(scroll, 'mouseout', () => clearExprTypeTimeout());
+    subscriber.subscribe(scroll, 'keydown', () => clearExprTypeTimeout());
 
     // Setup for clearing
     editor.onDidDestroy(() => deactivate());
@@ -130,7 +130,7 @@ export function attach(editorView: JQuery, editor: AtomCore.IEditor) {
 }
 
 
-function pixelPositionFromMouseEvent(editorView, event: MouseEvent) {
+function pixelPositionFromMouseEvent(editorView: JQuery, event: MouseEvent) {
     var clientX = event.clientX, clientY = event.clientY;
     var linesClientRect = getFromShadowDom(editorView, '.lines')[0].getBoundingClientRect();
     var top = clientY - linesClientRect.top;

lib/main/atom/components/tsView.ts

@@ -25,7 +25,7 @@ export function spanToRange(span: TextSpan): TextBuffer.IRange {
   return locationsToRange(span.start, span.end)
 }
 
-export function locationsToRange(start, end): TextBuffer.IRange {
+export function locationsToRange(start: LocationQuery, end: LocationQuery): TextBuffer.IRange {
   return new Range(locationToPoint(start), locationToPoint(end))
 }