Skip to content

Angular 5 - Merge or PR? #454

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
BillSheldon-HunterIndustries opened this issue Nov 1, 2017 · 4 comments
Closed

Angular 5 - Merge or PR? #454

BillSheldon-HunterIndustries opened this issue Nov 1, 2017 · 4 comments

Comments

@BillSheldon-HunterIndustries
Copy link
Contributor

With the launch of Angular 5, is the plan to update the main branch via a new PR or merge the existing Angular 5 branch into the master (with appropriate updates from RC)?

@MarkPieszak
Copy link
Member

MarkPieszak commented Nov 1, 2017

Yes I'll definitely merge it in there! Let me just make sure things are working and I'll get it in tomorrow morning 👍 Apologies on the delay.

I'll try to get HttpTransferCacheModule in there, if not I can get that in, in a later PR.

#437

@naveedahmed1
Copy link

Sounds great! HttpTransferCacheModule is much needed :)

@MarkPieszak
Copy link
Member

Merged ✨
but unfortunately couldn't fix ServerTransfer quickly enough, for the time being you could keep the existing Transfer technique we had already built-in to the project!

Hopefully we can figure out the root cause of why ServerTransfer is breaking server renders with ASPNET.

@naveedahmed1
Copy link

Thank you so much, but I think even the old Transfer technique is broken.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants