Skip to content

HMR Prevents removing compiler from bundle in AOT #318

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
hheexx opened this issue Jun 27, 2017 · 4 comments
Closed

HMR Prevents removing compiler from bundle in AOT #318

hheexx opened this issue Jun 27, 2017 · 4 comments
Labels
Needs Investigation

Comments

@hheexx
Copy link

hheexx commented Jun 27, 2017 •
edited
Loading

HMR code in main.browser.ts (lines 9-18) couses webpack to include compiler in the bundle when in AOT mode.
https://i.gyazo.com/b42010db35a79fc6a6d4d7b730655a50.png
@MarkPieszak
Copy link
Member

When building Production mode?

@hheexx
Copy link
Author

hheexx commented Jun 28, 2017

yes!

@MarkPieszak
Copy link
Member

Were you using source-map-explorer after running npm run build:aot and checking the dist folder?

@hheexx
Copy link
Author

hheexx commented Jun 29, 2017 •
edited
Loading

webpack-bundle-analyzer.

Also I checked bundle sizes and there is half a meg of difference.

@MarkPieszak MarkPieszak mentioned this issue Aug 19, 2017
Merged
8 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Needs Investigation
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@hheexx @MarkPieszak