Skip to content
This repository was archived by the owner on Aug 30, 2019. It is now read-only.

Commit ac0dcde

Browse files
author
Ricardo Machado
committed
Improves coverage of the componentWillReceiveProps
1 parent deb0cf6 commit ac0dcde

File tree

4 files changed

+1436
-243
lines changed

4 files changed

+1436
-243
lines changed

components/calendar/calendar.js

+22-2
Original file line numberDiff line numberDiff line change
@@ -23,7 +23,9 @@ const {
2323
function processProps(props) {
2424
const { initialDates, maxDate, minDate, selectionType } = props;
2525
const maxLimit = maxDate ? normalizeDate(new Date(maxDate), 23, 59, 59, 999) : null;
26-
const renderDate = normalizeDate(((initialDates && initialDates.length) ? new Date(initialDates[0]) : new Date()));
26+
const renderDate = normalizeDate(((initialDates && initialDates.length && initialDates[0])
27+
? new Date(initialDates[0])
28+
: new Date()));
2729

2830
let minLimit = minDate ? normalizeDate(new Date(minDate)) : null;
2931
let selectedDates = [null, null];
@@ -78,7 +80,25 @@ export default class Calendar extends Component {
7880
}
7981

8082
componentWillReceiveProps(newProps) {
81-
this.setState(() => processProps(newProps));
83+
const { initialDates, maxDate, minDate, selectionType } = newProps;
84+
85+
let propsChanged = (
86+
(maxDate !== this.props.maxDate) ||
87+
(minDate !== this.props.minDate) ||
88+
(selectionType !== this.props.selectionType)
89+
);
90+
91+
if (initialDates) {
92+
if (this.props.initialDates) {
93+
propsChanged = propsChanged || initialDates.some((item, idx) => item !== this.props.initialDates[idx]);
94+
} else {
95+
propsChanged = true;
96+
}
97+
}
98+
99+
if (propsChanged) {
100+
this.setState(() => processProps(newProps));
101+
}
82102
}
83103

84104
/**

0 commit comments

Comments
 (0)