API: Call finalize in more Series methods [WIP]

Progress towards pandas-dev#28283. This
calls `finalize` for all the public series methods where I think it
makes sense.

Author: TomAugspurger

pandas/core/series.py

@@ -3956,6 +3956,7 @@ def align(
             fill_axis=fill_axis,
             broadcast_axis=broadcast_axis,
         )
+        # TODO(API): Should these be method=align-left, and align-right?
         a.__finalize__((self, other), method="align")
         b.__finalize__((self, other), method="align")
         return a, b

pandas/core/strings.py

@@ -951,6 +951,7 @@ def _str_extract_frame(arr, pat, flags=0):
     str_extract(expand=True), and always returns a DataFrame.
 
     """
+    # TODO: why doesn't this go through wrap_result?
     from pandas import DataFrame
 
     regex = re.compile(pat, flags=flags)
@@ -2253,11 +2254,15 @@ def cons_row(x):
             index = self._orig.index
             if expand:
                 cons = self._orig._constructor_expanddim
-                result = cons(result, columns=name, index=index, dtype=dtype)
+                result = cons(
+                    result, columns=name, index=index, dtype=dtype
+                ).__finalize__(self._orig, method="str")
             else:
                 # Must be a Series
                 cons = self._orig._constructor
-                result = cons(result, name=name, index=index, dtype=dtype)
+                result = cons(result, name=name, index=index, dtype=dtype).__finalize__(
+                    self._orig, method="str"
+                )
             return result
 
     def _get_series_list(self, others):

pandas/tests/generic/test_finalize.py

@@ -23,6 +23,30 @@
     (pd.Series, ([0, 0],), operator.methodcaller("drop_duplicates")),
     (pd.Series, ([0, 0],), operator.methodcaller("duplicated")),
     (pd.Series, ([0, 0],), operator.methodcaller("round")),
+    (pd.Series, ([0, 0],), operator.methodcaller("rename", lambda x: x + 1)),
+    (pd.Series, ([0, 0],), operator.methodcaller("rename", "name")),
+    (pd.Series, ([0, 0],), operator.methodcaller("set_axis", ["a", "b"])),
+    (pd.Series, ([0, 0],), operator.methodcaller("reindex", [1, 0])),
+    (pd.Series, ([0, 0],), operator.methodcaller("drop", [0])),
+    (pd.Series, (pd.array([0, pd.NA]),), operator.methodcaller("fillna", 0)),
+    (pd.Series, ([0, 0],), operator.methodcaller("replace", {0: 1})),
+    (pd.Series, ([0, 0],), operator.methodcaller("shift")),
+    (pd.Series, ([0, 0],), operator.methodcaller("isin", [0, 1])),
+    (pd.Series, ([0, 0],), operator.methodcaller("between", 0, 2)),
+    (pd.Series, ([0, 0],), operator.methodcaller("isna")),
+    (pd.Series, ([0, 0],), operator.methodcaller("isnull")),
+    (pd.Series, ([0, 0],), operator.methodcaller("notna")),
+    (pd.Series, ([0, 0],), operator.methodcaller("notnull")),
+    (
+        pd.Series,
+        ([0], pd.period_range("2000", periods=1)),
+        operator.methodcaller("to_timestamp"),
+    ),
+    (
+        pd.Series,
+        ([0], pd.date_range("2000", periods=1)),
+        operator.methodcaller("to_period"),
+    ),
 ]
 
 
@@ -34,6 +58,31 @@ def ndframe_method(request):
     return request.param
 
 
+@pytest.mark.parametrize(
+    "method",
+    [
+        operator.methodcaller("upper"),
+        pytest.param(
+            operator.methodcaller("extract", r"(\w)(\d)"),
+            marks=pytest.mark.xfail(reason="finalize not called."),
+        ),
+    ],
+)
+def test_string_method(method):
+    s = pd.Series(["a1"])
+    s.attrs = {"a": 1}
+    result = method(s.str)
+    assert result.attrs == {"a": 1}
+
+
+@pytest.mark.xfail(reason="TODO")
+def test_datetime_method():
+    s = pd.Series(pd.date_range("2000", periods=4))
+    s.attrs = {"a": 1}
+    result = s.dt.date
+    assert result.attrs == {"a": 1}
+
+
 def test_finalize_called(ndframe_method):
     cls, init_args, method = ndframe_method
     ndframe = cls(*init_args)