Skip to content

Commit 58f2892

Browse files
committed
BUG: Fixed merging on tz-aware
Closes pandas-dev#25014
1 parent b9f2e2b commit 58f2892

File tree

3 files changed

+24
-0
lines changed

3 files changed

+24
-0
lines changed

doc/source/whatsnew/v0.24.1.rst

+1
Original file line numberDiff line numberDiff line change
@@ -23,6 +23,7 @@ Fixed Regressions
2323
- Bug in :meth:`DataFrame.itertuples` with ``records`` orient raising an ``AttributeError`` when the ``DataFrame`` contained more than 255 columns (:issue:`24939`)
2424
- Bug in :meth:`DataFrame.itertuples` orient converting integer column names to strings prepended with an underscore (:issue:`24940`)
2525
- Fixed regression in :class:`Index.intersection` incorrectly sorting the values by default (:issue:`24959`).
26+
- Fixed regression in :func:`merge` when merging an empty ``DataFrame`` with multiple timezone-aware columns on one of the timezone-aware columns (:issue:`25014`).
2627

2728
.. _whatsnew_0241.enhancements:
2829

pandas/core/internals/concat.py

+5
Original file line numberDiff line numberDiff line change
@@ -219,6 +219,11 @@ def get_reindexed_values(self, empty_dtype, upcasted_na):
219219

220220
else:
221221
for ax, indexer in self.indexers.items():
222+
# GH-25014: get_upcasted_na returns iNaT, but
223+
# DatetimeArray.take expects NaT.
224+
# TODO: update get_empty_dtype_and_na to use EAs earlier?
225+
if is_datetime64tz_dtype(values) and fill_value == tslibs.iNaT:
226+
fill_value = tslibs.NaT
222227
values = algos.take_nd(values, indexer, axis=ax,
223228
fill_value=fill_value)
224229

pandas/tests/reshape/merge/test_merge.py

+18
Original file line numberDiff line numberDiff line change
@@ -616,6 +616,24 @@ def test_merge_on_datetime64tz(self):
616616
assert result['value_x'].dtype == 'datetime64[ns, US/Eastern]'
617617
assert result['value_y'].dtype == 'datetime64[ns, US/Eastern]'
618618

619+
def test_merge_on_datetime64tz_empty(self):
620+
# https://github.com/pandas-dev/pandas/issues/25014
621+
dtz = pd.DatetimeTZDtype(tz='UTC')
622+
right = pd.DataFrame({'date': [pd.Timestamp('2018', tz=dtz.tz)],
623+
'value': [4.0],
624+
'date2': [pd.Timestamp('2019', tz=dtz.tz)]},
625+
columns=['date', 'value', 'date2'])
626+
left = right[:0]
627+
result = left.merge(right, on='date')
628+
expected = pd.DataFrame({
629+
'value_x': pd.Series(dtype=float),
630+
'date2_x': pd.Series(dtype=dtz),
631+
'date': pd.Series(dtype=dtz),
632+
'value_y': pd.Series(dtype=float),
633+
'date2_y': pd.Series(dtype=dtz),
634+
}, columns=['value_x', 'date2_x', 'date', 'value_y', 'date2_y'])
635+
tm.assert_frame_equal(result, expected)
636+
619637
def test_merge_datetime64tz_with_dst_transition(self):
620638
# GH 18885
621639
df1 = pd.DataFrame(pd.date_range(

0 commit comments

Comments
 (0)