Skip to content

Commit eefa9ab

Browse files
committed
TST: Remove buggy assertions
It's unclear what the expected behavior of Series.append(DataFrame) is. Removing these assertions for now. xref pandas-dev/pandas#30975
1 parent 0b9a62b commit eefa9ab

File tree

1 file changed

+0
-28
lines changed

1 file changed

+0
-28
lines changed

dask/dataframe/tests/test_multi.py

Lines changed: 0 additions & 28 deletions
Original file line numberDiff line numberDiff line change
@@ -1823,20 +1823,10 @@ def test_append2():
18231823

18241824
assert_eq(ddf1.append(ddf2), ddf1.compute().append(ddf2.compute(), **concat_kwargs))
18251825
assert_eq(ddf2.append(ddf1), ddf2.compute().append(ddf1.compute(), **concat_kwargs))
1826-
# Series + DataFrame
1827-
with pytest.warns(None):
1828-
# RuntimeWarning from pandas on comparing int and str
1829-
assert_eq(ddf1.a.append(ddf2), ddf1.a.compute().append(ddf2.compute()))
1830-
assert_eq(ddf2.a.append(ddf1), ddf2.a.compute().append(ddf1.compute()))
18311826

18321827
# different columns
18331828
assert_eq(ddf1.append(ddf3), ddf1.compute().append(ddf3.compute(), **concat_kwargs))
18341829
assert_eq(ddf3.append(ddf1), ddf3.compute().append(ddf1.compute(), **concat_kwargs))
1835-
# Series + DataFrame
1836-
with pytest.warns(None):
1837-
# RuntimeWarning from pandas on comparing int and str
1838-
assert_eq(ddf1.a.append(ddf3), ddf1.a.compute().append(ddf3.compute()))
1839-
assert_eq(ddf3.b.append(ddf1), ddf3.b.compute().append(ddf1.compute()))
18401830

18411831
# Dask + pandas
18421832
assert_eq(
@@ -1847,15 +1837,6 @@ def test_append2():
18471837
ddf2.append(ddf1.compute()),
18481838
ddf2.compute().append(ddf1.compute(), **concat_kwargs),
18491839
)
1850-
# Series + DataFrame
1851-
with pytest.warns(None):
1852-
# RuntimeWarning from pandas on comparing int and str
1853-
assert_eq(
1854-
ddf1.a.append(ddf2.compute()), ddf1.a.compute().append(ddf2.compute())
1855-
)
1856-
assert_eq(
1857-
ddf2.a.append(ddf1.compute()), ddf2.a.compute().append(ddf1.compute())
1858-
)
18591840

18601841
# different columns
18611842
assert_eq(
@@ -1866,15 +1847,6 @@ def test_append2():
18661847
ddf3.append(ddf1.compute()),
18671848
ddf3.compute().append(ddf1.compute(), **concat_kwargs),
18681849
)
1869-
# Series + DataFrame
1870-
with pytest.warns(None):
1871-
# RuntimeWarning from pandas on comparing int and str
1872-
assert_eq(
1873-
ddf1.a.append(ddf3.compute()), ddf1.a.compute().append(ddf3.compute())
1874-
)
1875-
assert_eq(
1876-
ddf3.b.append(ddf1.compute()), ddf3.b.compute().append(ddf1.compute())
1877-
)
18781850

18791851

18801852
def test_append_categorical():

0 commit comments

Comments
 (0)