client: Fix bool operator on init and ongoing use

rzr · rzr · commit d899527c0167 · 2019-01-04T11:56:04.000+01:00
When iterating we make sure client's socket is not closing since _tcp_client remains after close. This was tested on nuleo-f767zi using project webthing-arduino Change-Id: Ie465fe59009c33957dad97f1c70b4dc3af3b2ebe Forwarded: stm32duino#17 Signed-off-by: Philippe Coval <p.coval@samsung.com>
diff --git a/src/EthernetClient.cpp b/src/EthernetClient.cpp
@@ -9,7 +9,8 @@ extern "C" {
 #include "EthernetServer.h"
 #include "Dns.h"
 
-EthernetClient::EthernetClient() {
+EthernetClient::EthernetClient()
+  :_tcp_client(NULL) {
 }
 
 /* Deprecated constructor. Keeps compatibility with W5100 architecture
@@ -181,7 +182,7 @@ uint8_t EthernetClient::status() {
 // EthernetServer::available() as the condition in an if-statement.
 
 EthernetClient::operator bool() {
-  return _tcp_client != NULL;
+  return (_tcp_client && (_tcp_client->state != TCP_CLOSING));
 }
 
 bool EthernetClient::operator==(const EthernetClient& rhs) {

Original file line number	Diff line number	Diff line change
`@@ -9,7 +9,8 @@ extern "C" {`
`9`	`9`	`#include "EthernetServer.h"`
`10`	`10`	`#include "Dns.h"`
`11`	`11`
`12`		`-EthernetClient::EthernetClient() {`
	`12`	`+EthernetClient::EthernetClient()`
	`13`	`+ :_tcp_client(NULL) {`
`13`	`14`	`}`
`14`	`15`
`15`	`16`	`/* Deprecated constructor. Keeps compatibility with W5100 architecture`
`@@ -181,7 +182,7 @@ uint8_t EthernetClient::status() {`
`181`	`182`	`// EthernetServer::available() as the condition in an if-statement.`
`182`	`183`
`183`	`184`	`EthernetClient::operator bool() {`
`184`		`- return _tcp_client != NULL;`
	`185`	`+ return (_tcp_client && (_tcp_client->state != TCP_CLOSING));`
`185`	`186`	`}`
`186`	`187`
`187`	`188`	`bool EthernetClient::operator==(const EthernetClient& rhs) {`