Updated check_bipartite_graph_dfs.py #9525

debnath003 · 2023-10-02T18:57:43Z

Describe your change:

Updated the check_bipartite_graph_dfs.py in the graph folder which will reduce the time complexity. Furthermore I also included doctest module for testing some test cases included in the code.

Add an algorithm?
Fix a bug or typo in an existing algorithm?
Documentation change?

Checklist:

for more information, see https://pre-commit.ci

debnath003 · 2023-10-02T19:15:06Z

@tianyizheng02 please merge my PR, awaiting your review

debnath003 · 2023-10-03T04:51:42Z

@tianyizheng02 awaiting your review #9525

debnath003 · 2023-10-03T06:51:54Z

@tianyizheng02 could you please approve my PR review #9525? This is my first time contributing in this repository. Also please include hacktoberfest accepted label! Thanks again

debnath003 · 2023-10-03T10:33:31Z

@tianyizheng02 please look after this PR #9525 and merge this PR for hacktoberfest

debnath003 · 2023-10-03T15:28:05Z

@tianyizheng02 please look after #9525 and merge the PR for hacktoberfest

debnath003 · 2023-10-04T17:33:05Z

@tianyizheng02 @cclauss please look after this PR #9525 and merge the PR, so that it can be eligible for hacktoberfest. Please also add hacktoberfest-accepted label. Thanks a lot!

graphs/check_bipartite_graph_dfs.py

Co-authored-by: Christian Clauss <[email protected]>

graphs/check_bipartite_graph_dfs.py

Co-authored-by: Christian Clauss <[email protected]>

graphs/check_bipartite_graph_dfs.py

for more information, see https://pre-commit.ci

debnath003 · 2023-10-04T18:15:24Z

if you do pipx install pre-commit and the pre-commit install at the root of this repo's directory then black (code formatting) and ruff (linting) will run automatically on each git commit.

I have actually done that in vscode, but the change that you have given seemingly shows some format errors, which is alright; Apart from that is the code okay, as edited by the changes that you have suggested? @cclauss

debnath003 · 2023-10-04T18:18:14Z

@cclauss looks like the code is having some error, in build, could you please point out the error?

cclauss · 2023-10-04T18:19:54Z

https://github.com/TheAlgorithms/Python/actions/runs/6409870201/job/17401971717?pr=9525#step:6:710

Scroll to line 710

debnath003 · 2023-10-04T19:35:16Z

@cclauss I have made the required changes, and the checks are also correct, could you please review that and merge the PR? It will be very helpful in hacktoberfest also if you add the hacktoberfest-accepted label

debnath003 · 2023-10-05T14:46:26Z

@cclauss @tianyizheng02 please someone check the review and approve my PR! Awaiting for review!

This is complex code so let's use self-documenting function and variable names to help readers to understand. We should not shorten names to simplify the code formatting but use understandable name and leave to code formatting to psf/black. I am not sure if `nbor` was supposed to be `neighbour`. ;-)

cclauss · 2023-10-05T15:39:54Z

This is complex code so let's use function and variable names that are self-documenting to help readers understand.

We should not shorten names to simplify the code formatting but use understandable names and leave the code formatting to psf/black.

I am unsure if nbor was supposed to be neighbour. ;-)

debnath003 · 2023-10-05T15:45:51Z

All the checks have passed! @cclauss

debnath003 · 2023-10-05T15:47:02Z

This is complex code so let's use function and variable names that are self-documenting to help readers understand.

We should not shorten names to simplify the code formatting but use understandable names and leave the code formatting to psf/black.

I am unsure if nbor was supposed to be neighbour. ;-)

I actually did it intentionally, so that my formatting can be correct according to the ruff linter 😅 @cclauss

debnath003 · 2023-10-05T16:46:10Z

@cclauss could you please check this PR once again?

cclauss · 2023-10-05T17:31:43Z

https://docs.astral.sh/ruff/faq/#is-ruff-compatible-with-black ;-) They both run in our pre-commit.

Python/.pre-commit-config.yaml

Lines 18 to 26 in 87494f1

    
           - repo: https://github.com/astral-sh/ruff-pre-commit 
        
             rev: v0.0.292 
        
             hooks: 
        
               - id: ruff 
        
           - repo: https://github.com/psf/black 
        
             rev: 23.9.1 
        
             hooks: 
        
               - id: black

cclauss

Nice work!!!

debnath003 · 2023-10-05T17:33:18Z

https://docs.astral.sh/ruff/faq/#is-ruff-compatible-with-black ;-) They both run in our pre-commit.

Python/.pre-commit-config.yaml

Lines 18 to 26 in 87494f1

- repo: https://github.com/astral-sh/ruff-pre-commit

rev: v0.0.292

hooks:

- id: ruff

- repo: https://github.com/psf/black

rev: 23.9.1

hooks:

- id: black

I think I forgot it 😅

debnath003 · 2023-10-05T17:33:58Z

Nice work!!!

Please add hacktoberfest-accepted label so that it can be accepted in hacktoberfest @cclauss

cclauss · 2023-10-05T17:41:11Z

Hacktoberfest knows this repo... They will accept this automatically but just in case...

debnath003 · 2023-10-05T17:42:10Z

Thanks a lot @cclauss !

* Create dijkstra_algorithm.py * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci * Update dijkstra_algorithm.py * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci * Update dijkstra_algorithm.py * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci * Update dijkstra_algorithm.py * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci * Delete greedy_methods/dijkstra_algorithm.py * Update check_bipartite_graph_dfs.py * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci * Update check_bipartite_graph_dfs.py * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci * Update graphs/check_bipartite_graph_dfs.py Co-authored-by: Christian Clauss <[email protected]> * Update graphs/check_bipartite_graph_dfs.py Co-authored-by: Christian Clauss <[email protected]> * Update check_bipartite_graph_dfs.py * Update check_bipartite_graph_dfs.py * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci * Update check_bipartite_graph_dfs.py * Update check_bipartite_graph_dfs.py * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci * Update check_bipartite_graph_dfs.py * Update check_bipartite_graph_dfs.py * Update check_bipartite_graph_dfs.py * Let's use self-documenting variable names This is complex code so let's use self-documenting function and variable names to help readers to understand. We should not shorten names to simplify the code formatting but use understandable name and leave to code formatting to psf/black. I am not sure if `nbor` was supposed to be `neighbour`. ;-) * Update check_bipartite_graph_dfs.py --------- Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com> Co-authored-by: Christian Clauss <[email protected]>

debnath003 and others added 10 commits October 2, 2023 23:14

Create dijkstra_algorithm.py

ffa6738

[pre-commit.ci] auto fixes from pre-commit.com hooks

6a04fce

for more information, see https://pre-commit.ci

Update dijkstra_algorithm.py

8faba24

[pre-commit.ci] auto fixes from pre-commit.com hooks

8521a6b

for more information, see https://pre-commit.ci

Update dijkstra_algorithm.py

e0da2c3

[pre-commit.ci] auto fixes from pre-commit.com hooks

934272e

for more information, see https://pre-commit.ci

Update dijkstra_algorithm.py

c2e4771

[pre-commit.ci] auto fixes from pre-commit.com hooks

df722eb

for more information, see https://pre-commit.ci

Delete greedy_methods/dijkstra_algorithm.py

2888c8b

Update check_bipartite_graph_dfs.py

1de4cb5

algorithms-keeper bot added enhancement This PR modified some existing files awaiting reviews This PR is ready to be reviewed labels Oct 2, 2023

pre-commit-ci bot and others added 3 commits October 2, 2023 18:59

[pre-commit.ci] auto fixes from pre-commit.com hooks

5857640

for more information, see https://pre-commit.ci

Update check_bipartite_graph_dfs.py

4d4bb3e

[pre-commit.ci] auto fixes from pre-commit.com hooks

307388b

for more information, see https://pre-commit.ci

cclauss reviewed Oct 4, 2023

View reviewed changes

graphs/check_bipartite_graph_dfs.py Outdated Show resolved Hide resolved

Update graphs/check_bipartite_graph_dfs.py

b7522ba

Co-authored-by: Christian Clauss <[email protected]>

cclauss reviewed Oct 4, 2023

View reviewed changes

graphs/check_bipartite_graph_dfs.py Outdated Show resolved Hide resolved

debnath003 and others added 2 commits October 4, 2023 23:29

Update graphs/check_bipartite_graph_dfs.py

8f46b7f

Co-authored-by: Christian Clauss <[email protected]>

Update check_bipartite_graph_dfs.py

81d6e00

cclauss reviewed Oct 4, 2023

View reviewed changes

graphs/check_bipartite_graph_dfs.py Outdated Show resolved Hide resolved

algorithms-keeper bot added the tests are failing Do not merge until tests pass label Oct 4, 2023

Update check_bipartite_graph_dfs.py

2f62202

cclauss requested changes Oct 4, 2023

View reviewed changes

graphs/check_bipartite_graph_dfs.py Outdated Show resolved Hide resolved

[pre-commit.ci] auto fixes from pre-commit.com hooks

afd7c07

for more information, see https://pre-commit.ci

debnath003 added 3 commits October 4, 2023 23:57

Update check_bipartite_graph_dfs.py

9b949a0

Update check_bipartite_graph_dfs.py

779ccf0

Update check_bipartite_graph_dfs.py

6d5ed2a

algorithms-keeper bot removed the tests are failing Do not merge until tests pass label Oct 4, 2023

debnath003 requested a review from cclauss October 4, 2023 19:35

cclauss added 2 commits October 5, 2023 17:35

Update check_bipartite_graph_dfs.py

498438b

algorithms-keeper bot added tests are failing Do not merge until tests pass and removed tests are failing Do not merge until tests pass labels Oct 5, 2023

cclauss approved these changes Oct 5, 2023

View reviewed changes

algorithms-keeper bot removed the awaiting reviews This PR is ready to be reviewed label Oct 5, 2023

cclauss merged commit b76115e into TheAlgorithms:master Oct 5, 2023

cclauss added the hacktoberfest-accepted Accepted to be counted towards Hacktoberfest label Oct 5, 2023

isidroas mentioned this pull request Jan 25, 2025

dh isidroas/Python#1

Closed

14 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Updated check_bipartite_graph_dfs.py #9525

Updated check_bipartite_graph_dfs.py #9525

debnath003 commented Oct 2, 2023

debnath003 commented Oct 2, 2023

debnath003 commented Oct 3, 2023

debnath003 commented Oct 3, 2023

debnath003 commented Oct 3, 2023

debnath003 commented Oct 3, 2023

debnath003 commented Oct 4, 2023

debnath003 commented Oct 4, 2023

debnath003 commented Oct 4, 2023

cclauss commented Oct 4, 2023 •

edited

Loading

debnath003 commented Oct 4, 2023

debnath003 commented Oct 5, 2023

cclauss commented Oct 5, 2023 •

edited

Loading

debnath003 commented Oct 5, 2023

debnath003 commented Oct 5, 2023

debnath003 commented Oct 5, 2023

cclauss commented Oct 5, 2023

cclauss left a comment

debnath003 commented Oct 5, 2023

debnath003 commented Oct 5, 2023 •

edited

Loading

cclauss commented Oct 5, 2023

debnath003 commented Oct 5, 2023

Updated check_bipartite_graph_dfs.py #9525

Updated check_bipartite_graph_dfs.py #9525

Conversation

debnath003 commented Oct 2, 2023

Describe your change:

Checklist:

debnath003 commented Oct 2, 2023

debnath003 commented Oct 3, 2023

debnath003 commented Oct 3, 2023

debnath003 commented Oct 3, 2023

debnath003 commented Oct 3, 2023

debnath003 commented Oct 4, 2023

debnath003 commented Oct 4, 2023

debnath003 commented Oct 4, 2023

cclauss commented Oct 4, 2023 • edited Loading

debnath003 commented Oct 4, 2023

debnath003 commented Oct 5, 2023

cclauss commented Oct 5, 2023 • edited Loading

debnath003 commented Oct 5, 2023

debnath003 commented Oct 5, 2023

debnath003 commented Oct 5, 2023

cclauss commented Oct 5, 2023

cclauss left a comment

Choose a reason for hiding this comment

debnath003 commented Oct 5, 2023

debnath003 commented Oct 5, 2023 • edited Loading

cclauss commented Oct 5, 2023

debnath003 commented Oct 5, 2023

cclauss commented Oct 4, 2023 •

edited

Loading

cclauss commented Oct 5, 2023 •

edited

Loading

debnath003 commented Oct 5, 2023 •

edited

Loading