Skip to content

Changing Name of file and adding doctests in file. #9504

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 2 commits into from
Closed

Changing Name of file and adding doctests in file. #9504

wants to merge 2 commits into from

Conversation

AasheeshLikePanner
Copy link
Contributor

Describe your change:

Change the File and Added doctests in maths/binary_exponentiation_2.py
Fixes Issue #9478

  • Add an algorithm?
  • Fix a bug or typo in an existing algorithm?
  • Documentation change?

Checklist:

  • I have read CONTRIBUTING.md.
  • This pull request is all my own work -- I have not plagiarized.
  • I know that pull requests will not be merged if they fail the automated tests.
  • This PR only changes one algorithm file. To ease review, please open separate PRs for separate algorithms.
  • All new Python files are placed inside an existing directory.
  • All filenames are in all lowercase characters with no spaces or dashes.
  • All functions and variable names follow Python naming conventions.
  • All function parameters and return values are annotated with Python type hints.
  • All functions have doctests that pass the automated testing.
  • All new algorithms include at least one URL that points to Wikipedia or another similar explanation.
  • If this pull request resolves one or more open issues then the description above includes the issue number(s) with a closing keyword: "Fixes #ISSUE-NUMBER".
    maths/binary_exponentiation_2.py needs to be renamed #9478

@algorithms-keeper algorithms-keeper bot added enhancement This PR modified some existing files awaiting reviews This PR is ready to be reviewed labels Oct 2, 2023
@AasheeshLikePanner AasheeshLikePanner mentioned this pull request Oct 2, 2023
Closed
tianyizheng02
tianyizheng02 requested changes Oct 2, 2023
View reviewed changes
DIRECTORY.md
@@ -548,7 +548,7 @@
* [Basic Maths](maths/basic_maths.py)
* [Binary Exp Mod](maths/binary_exp_mod.py)
* [Binary Exponentiation](maths/binary_exponentiation.py)
* [Binary Exponentiation 2](maths/binary_exponentiation_2.py)
* [Binary Exponentiation 2](maths/binary_multiplication.py)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please don't modify DIRECTORY.md. This file is auto-generated with a script.

maths/binary_multiplication.py
Comment on lines +49 to +52
if __name__ == "__main__":
import doctest

doctest.testmod()
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The main block should be placed at the bottom of the file.

maths/binary_multiplication.py

doctest.testmod()


def b_expo_mod(a: int, b: int, c: int) -> int:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This function also needs doctests

@tianyizheng02 tianyizheng02 linked an issue Oct 2, 2023 that may be closed by this pull request
maths/binary_exponentiation_2.py needs to be renamed #9478
Closed
@AasheeshLikePanner AasheeshLikePanner closed this by deleting the head repository Oct 2, 2023
@tianyizheng02
Copy link
Contributor

??? Ok then

@AasheeshLikePanner
Copy link
Contributor Author

AasheeshLikePanner commented Oct 2, 2023 •
edited
Loading

Can you please check this one Pr. I am new to git i am not able to change things in this PR so I made this new repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tianyizheng02 tianyizheng02 tianyizheng02 requested changes

Assignees
No one assigned
Labels
awaiting reviews This PR is ready to be reviewed enhancement This PR modified some existing files
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

maths/binary_exponentiation_2.py needs to be renamed
2 participants
@AasheeshLikePanner @tianyizheng02