Skip to content

Fix DeprecationWarning in local_weighted_learning.py (Attempt 2) #9170

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Oct 1, 2023
Merged

Fix DeprecationWarning in local_weighted_learning.py (Attempt 2) #9170

merged 3 commits into from
Oct 1, 2023

Conversation

tianyizheng02
Copy link
Contributor

Describe your change:

My previous PR #9165 didn't resolve the warning because np.dot() was still returning an np.ndarray rather than a scalar. I added a .item() call to explicitly extract the np.ndarray's scalar entry.

  • Add an algorithm?
  • Fix a bug or typo in an existing algorithm?
  • Documentation change?

Checklist:

  • I have read CONTRIBUTING.md.
  • This pull request is all my own work -- I have not plagiarized.
  • I know that pull requests will not be merged if they fail the automated tests.
  • This PR only changes one algorithm file. To ease review, please open separate PRs for separate algorithms.
  • All new Python files are placed inside an existing directory.
  • All filenames are in all lowercase characters with no spaces or dashes.
  • All functions and variable names follow Python naming conventions.
  • All function parameters and return values are annotated with Python type hints.
  • All functions have doctests that pass the automated testing.
  • All new algorithms include at least one URL that points to Wikipedia or another similar explanation.
  • If this pull request resolves one or more open issues then the description above includes the issue number(s) with a closing keyword: "Fixes #ISSUE-NUMBER".

@algorithms-keeper algorithms-keeper bot added enhancement This PR modified some existing files awaiting reviews This PR is ready to be reviewed labels Oct 1, 2023
@tianyizheng02
Copy link
Contributor Author

Looking at the build logs for this PR, I can confirm that local_weighted_learning.py no longer produces any warnings

@ChrisO345 ChrisO345 merged commit 280dfc1 into TheAlgorithms:master Oct 1, 2023
@algorithms-keeper algorithms-keeper bot removed the awaiting reviews This PR is ready to be reviewed label Oct 1, 2023
@tianyizheng02 tianyizheng02 deleted the fix-local-weighted branch October 1, 2023 04:08
sedatguzelsemme pushed a commit to sedatguzelsemme/Python that referenced this pull request Sep 15, 2024
@tianyizheng02 @sedatguzelsemme
Fix DeprecationWarning in local_weighted_learning.py (Attempt 2) (The…
8cbbec9 
…Algorithms#9170)

* Fix DeprecationWarning in local_weighted_learning.py

Fix DeprecationWarning that occurs during build due to converting an
np.ndarray to a scalar implicitly

* DeprecationWarning fix attempt 2
@isidroas isidroas mentioned this pull request Jan 25, 2025
Closed
14 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ChrisO345 ChrisO345 ChrisO345 approved these changes

Assignees
No one assigned
Labels
enhancement This PR modified some existing files
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tianyizheng02 @ChrisO345