Created harshad_numbers.py #9023
Conversation
for more information, see https://pre-commit.ci
Fixed a few errors
algorithms-keeper
bot
added
require tests
![algorithms-keeper[bot]](https://avatars.githubusercontent.com/in/235834?s=60&v=4){kind=small}
There was a problem hiding this comment.
Click here to look at the relevant links ⬇️
🔗 Relevant Links
Repository:
Python:
Automated review generated by algorithms-keeper. If there's any problem regarding this review, please open an issue about it.
algorithms-keeper commands and options
algorithms-keeper actions can be triggered by commenting on this PR:
@algorithms-keeper reviewto trigger the checks for only added pull request files@algorithms-keeper review-allto trigger the checks for all the pull request files, including the modified files. As we cannot post review comments on lines not part of the diff, this command will post all the messages in one comment.NOTE: Commands are in beta and so this feature is restricted only to a member or owner of the organization.
maths/harshad_numbers.py
Outdated
| """ | ||
|
|
||
|
|
||
| def int_to_base(number, base_of_interest): |
There was a problem hiding this comment.
As there is no test file in this pull request nor any test function or class in the file maths/harshad_numbers.py, please provide doctest for the function int_to_base
Please provide return type hint for the function: int_to_base. If the function does not return a value, please provide the type hint as: def function() -> None:
Please provide type hint for the parameter: number
Please provide type hint for the parameter: base_of_interest
maths/harshad_numbers.py
Outdated
| return result | ||
|
|
||
|
|
||
| def sum_of_digits(num: int, base_of_interest: int): |
There was a problem hiding this comment.
Please provide return type hint for the function: sum_of_digits. If the function does not return a value, please provide the type hint as: def function() -> None:
maths/harshad_numbers.py
Outdated
| return res | ||
|
|
||
|
|
||
| def all_harshad_numbers(num: int, base_of_interest: int): |
There was a problem hiding this comment.
Please provide return type hint for the function: all_harshad_numbers. If the function does not return a value, please provide the type hint as: def function() -> None:
maths/harshad_numbers.py
Outdated
| return result, numbers | ||
|
|
||
|
|
||
| def is_harshad_number(num: int, base_of_interest: int): |
There was a problem hiding this comment.
Please provide return type hint for the function: is_harshad_number. If the function does not return a value, please provide the type hint as: def function() -> None:
algorithms-keeper
bot
added
awaiting reviews
Added function type hints
algorithms-keeper
bot
removed
the
require type hints
There was a problem hiding this comment.
Click here to look at the relevant links ⬇️
🔗 Relevant Links
Repository:
Python:
Automated review generated by algorithms-keeper. If there's any problem regarding this review, please open an issue about it.
algorithms-keeper commands and options
algorithms-keeper actions can be triggered by commenting on this PR:
@algorithms-keeper reviewto trigger the checks for only added pull request files@algorithms-keeper review-allto trigger the checks for all the pull request files, including the modified files. As we cannot post review comments on lines not part of the diff, this command will post all the messages in one comment.NOTE: Commands are in beta and so this feature is restricted only to a member or owner of the organization.
maths/harshad_numbers.py
Outdated
| from typing import Tuple, List | ||
|
|
||
|
|
||
| def int_to_base(number: int, base_of_interest: int) -> str: |
There was a problem hiding this comment.
As there is no test file in this pull request nor any test function or class in the file maths/harshad_numbers.py, please provide doctest for the function int_to_base
Fixed depreciated Tuple and List usage
There was a problem hiding this comment.
Click here to look at the relevant links ⬇️
🔗 Relevant Links
Repository:
Python:
Automated review generated by algorithms-keeper. If there's any problem regarding this review, please open an issue about it.
algorithms-keeper commands and options
algorithms-keeper actions can be triggered by commenting on this PR:
@algorithms-keeper reviewto trigger the checks for only added pull request files@algorithms-keeper review-allto trigger the checks for all the pull request files, including the modified files. As we cannot post review comments on lines not part of the diff, this command will post all the messages in one comment.NOTE: Commands are in beta and so this feature is restricted only to a member or owner of the organization.
maths/harshad_numbers.py
Outdated
| """ | ||
|
|
||
|
|
||
| def int_to_base(number: int, base_of_interest: int) -> str: |
There was a problem hiding this comment.
As there is no test file in this pull request nor any test function or class in the file maths/harshad_numbers.py, please provide doctest for the function int_to_base
algorithms-keeper
bot
removed
the
tests are failing
Fixed incompatible types in assignments
There was a problem hiding this comment.
Click here to look at the relevant links ⬇️
🔗 Relevant Links
Repository:
Python:
Automated review generated by algorithms-keeper. If there's any problem regarding this review, please open an issue about it.
algorithms-keeper commands and options
algorithms-keeper actions can be triggered by commenting on this PR:
@algorithms-keeper reviewto trigger the checks for only added pull request files@algorithms-keeper review-allto trigger the checks for all the pull request files, including the modified files. As we cannot post review comments on lines not part of the diff, this command will post all the messages in one comment.NOTE: Commands are in beta and so this feature is restricted only to a member or owner of the organization.
maths/harshad_numbers.py
Outdated
| """ | ||
|
|
||
|
|
||
| def int_to_base(number: int, base_of_interest: int) -> str: |
There was a problem hiding this comment.
As there is no test file in this pull request nor any test function or class in the file maths/harshad_numbers.py, please provide doctest for the function int_to_base
Fixed incompatible type assignments
There was a problem hiding this comment.
Click here to look at the relevant links ⬇️
🔗 Relevant Links
Repository:
Python:
Automated review generated by algorithms-keeper. If there's any problem regarding this review, please open an issue about it.
algorithms-keeper commands and options
algorithms-keeper actions can be triggered by commenting on this PR:
@algorithms-keeper reviewto trigger the checks for only added pull request files@algorithms-keeper review-allto trigger the checks for all the pull request files, including the modified files. As we cannot post review comments on lines not part of the diff, this command will post all the messages in one comment.NOTE: Commands are in beta and so this feature is restricted only to a member or owner of the organization.
maths/harshad_numbers.py
Outdated
| @@ -0,0 +1,132 @@ | |||
| """ | |||
| A Harshad number is divisible by the sum of its digits in any base n. | |||
There was a problem hiding this comment.
Nitpicks:
- "Harshad" should be lowercase ("harshad" is not a name).
- What you're describing here is an all-harshad number. In general, a harshad number (or more specifically an n-harshad number) is a number that's divisible by the sum of its digits in some given base n.
maths/harshad_numbers.py
Outdated
| res = 0 | ||
| for char in num_str: | ||
| res += int(char, base_of_interest) |
There was a problem hiding this comment.
| res = 0 | |
| for char in num_str: | |
| res += int(char, base_of_interest) | |
| res = sum(int(char, base_of_interest) for char in num_str) |
Co-authored-by: Tianyi Zheng <[email protected]>
Co-authored-by: Tianyi Zheng <[email protected]>
Co-authored-by: Tianyi Zheng <[email protected]>
There was a problem hiding this comment.
Click here to look at the relevant links ⬇️
🔗 Relevant Links
Repository:
Python:
Automated review generated by algorithms-keeper. If there's any problem regarding this review, please open an issue about it.
algorithms-keeper commands and options
algorithms-keeper actions can be triggered by commenting on this PR:
@algorithms-keeper reviewto trigger the checks for only added pull request files@algorithms-keeper review-allto trigger the checks for all the pull request files, including the modified files. As we cannot post review comments on lines not part of the diff, this command will post all the messages in one comment.NOTE: Commands are in beta and so this feature is restricted only to a member or owner of the organization.
Co-authored-by: Tianyi Zheng <[email protected]>
There was a problem hiding this comment.
Click here to look at the relevant links ⬇️
🔗 Relevant Links
Repository:
Python:
Automated review generated by algorithms-keeper. If there's any problem regarding this review, please open an issue about it.
algorithms-keeper commands and options
algorithms-keeper actions can be triggered by commenting on this PR:
@algorithms-keeper reviewto trigger the checks for only added pull request files@algorithms-keeper review-allto trigger the checks for all the pull request files, including the modified files. As we cannot post review comments on lines not part of the diff, this command will post all the messages in one comment.NOTE: Commands are in beta and so this feature is restricted only to a member or owner of the organization.
Co-authored-by: Tianyi Zheng <[email protected]>
There was a problem hiding this comment.
Click here to look at the relevant links ⬇️
🔗 Relevant Links
Repository:
Python:
Automated review generated by algorithms-keeper. If there's any problem regarding this review, please open an issue about it.
algorithms-keeper commands and options
algorithms-keeper actions can be triggered by commenting on this PR:
@algorithms-keeper reviewto trigger the checks for only added pull request files@algorithms-keeper review-allto trigger the checks for all the pull request files, including the modified files. As we cannot post review comments on lines not part of the diff, this command will post all the messages in one comment.NOTE: Commands are in beta and so this feature is restricted only to a member or owner of the organization.
There was a problem hiding this comment.
Click here to look at the relevant links ⬇️
🔗 Relevant Links
Repository:
Python:
Automated review generated by algorithms-keeper. If there's any problem regarding this review, please open an issue about it.
algorithms-keeper commands and options
algorithms-keeper actions can be triggered by commenting on this PR:
@algorithms-keeper reviewto trigger the checks for only added pull request files@algorithms-keeper review-allto trigger the checks for all the pull request files, including the modified files. As we cannot post review comments on lines not part of the diff, this command will post all the messages in one comment.NOTE: Commands are in beta and so this feature is restricted only to a member or owner of the organization.
for more information, see https://pre-commit.ci
There was a problem hiding this comment.
Click here to look at the relevant links ⬇️
🔗 Relevant Links
Repository:
Python:
Automated review generated by algorithms-keeper. If there's any problem regarding this review, please open an issue about it.
algorithms-keeper commands and options
algorithms-keeper actions can be triggered by commenting on this PR:
@algorithms-keeper reviewto trigger the checks for only added pull request files@algorithms-keeper review-allto trigger the checks for all the pull request files, including the modified files. As we cannot post review comments on lines not part of the diff, this command will post all the messages in one comment.NOTE: Commands are in beta and so this feature is restricted only to a member or owner of the organization.
There was a problem hiding this comment.
Click here to look at the relevant links ⬇️
🔗 Relevant Links
Repository:
Python:
Automated review generated by algorithms-keeper. If there's any problem regarding this review, please open an issue about it.
algorithms-keeper commands and options
algorithms-keeper actions can be triggered by commenting on this PR:
@algorithms-keeper reviewto trigger the checks for only added pull request files@algorithms-keeper review-allto trigger the checks for all the pull request files, including the modified files. As we cannot post review comments on lines not part of the diff, this command will post all the messages in one comment.NOTE: Commands are in beta and so this feature is restricted only to a member or owner of the organization.
There was a problem hiding this comment.
Click here to look at the relevant links ⬇️
🔗 Relevant Links
Repository:
Python:
Automated review generated by algorithms-keeper. If there's any problem regarding this review, please open an issue about it.
algorithms-keeper commands and options
algorithms-keeper actions can be triggered by commenting on this PR:
@algorithms-keeper reviewto trigger the checks for only added pull request files@algorithms-keeper review-allto trigger the checks for all the pull request files, including the modified files. As we cannot post review comments on lines not part of the diff, this command will post all the messages in one comment.NOTE: Commands are in beta and so this feature is restricted only to a member or owner of the organization.
maths/harshad_numbers.py
Outdated
| if (base > 36) or (base < 2): | ||
| raise ValueError("'base' must be between 36 and 2 inclusive") |
There was a problem hiding this comment.
| if (base > 36) or (base < 2): | |
| raise ValueError("'base' must be between 36 and 2 inclusive") | |
| if base < 2 or base > 36: | |
| raise ValueError("'base' must be between 2 and 36 inclusive") |
Parentheses are unnecessary, and it's kinda strange to read the range backward
maths/harshad_numbers.py
Outdated
| res = 0 | ||
| for char in num_str: | ||
| res += int(char, base) |
There was a problem hiding this comment.
| res = 0 | |
| for char in num_str: | |
| res += int(char, base) | |
| res = sum(int(char, base) for char in num_str) |
Let's avoid manually looping when possible
maths/harshad_numbers.py
Outdated
| if (base > 36) or (base < 2): | ||
| raise ValueError("'base' must be between 36 and 2 inclusive") |
There was a problem hiding this comment.
| if (base > 36) or (base < 2): | |
| raise ValueError("'base' must be between 36 and 2 inclusive") | |
| if base < 2 or base > 36: | |
| raise ValueError("'base' must be between 2 and 36 inclusive") |
See previous comment
maths/harshad_numbers.py
Outdated
| numbers = [] | ||
| if limit >= 0: | ||
| for i in range(1, limit): | ||
| y = sum_of_digits(i, base) | ||
| if i % int(y, base) == 0: | ||
| numbers.append(int_to_base(i, base)) |
There was a problem hiding this comment.
| numbers = [] | |
| if limit >= 0: | |
| for i in range(1, limit): | |
| y = sum_of_digits(i, base) | |
| if i % int(y, base) == 0: | |
| numbers.append(int_to_base(i, base)) | |
| if limit < 0: | |
| return [] | |
| numbers = [ | |
| int_to_base(i, base) | |
| for i in range(1, limit) | |
| if i % int(sum_of_digits(i, base), base) == 0 | |
| ] |
Avoids a bit of nesting and some manual looping (though I could go either way with the list comprehension)
maths/harshad_numbers.py
Outdated
| if (base > 36) or (base < 2): | ||
| raise ValueError("'base' must be between 36 and 2 inclusive") |
There was a problem hiding this comment.
| if (base > 36) or (base < 2): | |
| raise ValueError("'base' must be between 36 and 2 inclusive") | |
| if base < 2 or base > 36: | |
| raise ValueError("'base' must be between 2 and 36 inclusive") |
Added doc test to int_to_base, fixed nested loop, other minor changes
algorithms-keeper
bot
removed
the
require tests
for more information, see https://pre-commit.ci
|
Thanks for your contribution! |
* Created harshad_numbers.py * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci * Update harshad_numbers.py Fixed a few errors * Update harshad_numbers.py Added function type hints * Update harshad_numbers.py Fixed depreciated Tuple and List usage * Update harshad_numbers.py Fixed incompatible types in assignments * Update harshad_numbers.py Fixed incompatible type assignments * Update maths/harshad_numbers.py Co-authored-by: Tianyi Zheng <[email protected]> * Update maths/harshad_numbers.py Co-authored-by: Tianyi Zheng <[email protected]> * Raised Value Error for negative inputs * Update maths/harshad_numbers.py Co-authored-by: Tianyi Zheng <[email protected]> * Update maths/harshad_numbers.py Co-authored-by: Tianyi Zheng <[email protected]> * Update maths/harshad_numbers.py Co-authored-by: Tianyi Zheng <[email protected]> * Update harshad_numbers.py * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci * Update harshad_numbers.py * Update harshad_numbers.py * Update harshad_numbers.py * Update harshad_numbers.py Added doc test to int_to_base, fixed nested loop, other minor changes * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci --------- Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com> Co-authored-by: Tianyi Zheng <[email protected]>
Describe your change:
Checklist: