Skip to content

Move and reimplement convert_number_to_words.py #8998

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Aug 20, 2023
Merged

Move and reimplement convert_number_to_words.py #8998

merged 2 commits into from
Aug 20, 2023

Conversation

tianyizheng02
Copy link
Contributor

Describe your change:

  • Move convert_number_to_words.py from web_programming/ to conversions/ (fixes web_programming/convert_number_to_words.py is not web programming #8881)
  • Reimplement the algorithm from scratch because the logic was very opaque and too heavily nested—I didn't consider the current implementation to be salvageable
  • Add support for the Western numbering system (both short and long) because the original implementation only supported the Indian numbering system (lakh and crore but no million, billion, etc)
  • Add extensive doctests and error handling to handle edge cases and disallow too-large inputs
  • Add an algorithm?
  • Fix a bug or typo in an existing algorithm?
  • Documentation change?

Checklist:

  • I have read CONTRIBUTING.md.
  • This pull request is all my own work -- I have not plagiarized.
  • I know that pull requests will not be merged if they fail the automated tests.
  • This PR only changes one algorithm file. To ease review, please open separate PRs for separate algorithms.
  • All new Python files are placed inside an existing directory.
  • All filenames are in all lowercase characters with no spaces or dashes.
  • All functions and variable names follow Python naming conventions.
  • All function parameters and return values are annotated with Python type hints.
  • All functions have doctests that pass the automated testing.
  • All new algorithms include at least one URL that points to Wikipedia or another similar explanation.
  • If this pull request resolves one or more open issues then the description above includes the issue number(s) with a closing keyword: "Fixes #ISSUE-NUMBER".

tianyizheng02 and others added 2 commits August 20, 2023 05:17
@tianyizheng02
Move and reimplement convert_number_to_words.py
7cdb54f 
- Move convert_number_to_words.py from web_programming/ to conversions/
- Reimplement the algorithm from scratch because the logic was very
  opaque and too heavily nested
- Add support for the Western numbering system (both short and long)
  because the original implementation only supported the Indian
  numbering system
- Add extensive doctests and error handling
updating DIRECTORY.md
52ce213
@tianyizheng02 tianyizheng02 requested a review from cclauss as a code owner August 20, 2023 12:30
@tianyizheng02 tianyizheng02 changed the title Move convert num to words Move and reimplement convert_number_to_words.py Aug 20, 2023
@cclauss cclauss merged commit 5ecb6ba into TheAlgorithms:master Aug 20, 2023
@tianyizheng02 tianyizheng02 deleted the move-convert-num-to-words branch August 20, 2023 12:37
sedatguzelsemme pushed a commit to sedatguzelsemme/Python that referenced this pull request Sep 15, 2024
@tianyizheng02 @sedatguzelsemme
Move and reimplement convert_number_to_words.py (TheAlgorithms#8998)
848417d 
* Move and reimplement convert_number_to_words.py

- Move convert_number_to_words.py from web_programming/ to conversions/
- Reimplement the algorithm from scratch because the logic was very
  opaque and too heavily nested
- Add support for the Western numbering system (both short and long)
  because the original implementation only supported the Indian
  numbering system
- Add extensive doctests and error handling

* updating DIRECTORY.md

---------

Co-authored-by: github-actions <${GITHUB_ACTOR}@users.noreply.github.com>
@isidroas isidroas mentioned this pull request Jan 25, 2025
Closed
14 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cclauss cclauss cclauss approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

web_programming/convert_number_to_words.py is not web programming
2 participants
@tianyizheng02 @cclauss