Skip to content

Consolidate find_min and find_min recursive and find_max and find_max_recursive #8960

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Aug 14, 2023
Merged

Consolidate find_min and find_min recursive and find_max and find_max_recursive #8960

merged 5 commits into from
Aug 14, 2023

Conversation

CaedenPH
Copy link
Contributor

Describe your change:

Merges find_min and find_min_recursive into just find_min.
Merges find_min and find_max_recursive into just find_max.

  • Add an algorithm?
  • Fix a bug or typo in an existing algorithm?
  • Documentation change?
  • Merge two different implementations into one file

Checklist:

  • I have read CONTRIBUTING.md.
  • This pull request is all my own work -- I have not plagiarized.
  • I know that pull requests will not be merged if they fail the automated tests.
  • This PR only changes one algorithm file. To ease review, please open separate PRs for separate algorithms.
  • All new Python files are placed inside an existing directory.
  • All filenames are in all lowercase characters with no spaces or dashes.
  • All functions and variable names follow Python naming conventions.
  • All function parameters and return values are annotated with Python type hints.
  • All functions have doctests that pass the automated testing.
  • All new algorithms include at least one URL that points to Wikipedia or another similar explanation.
  • If this pull request resolves one or more open issues then the description above includes the issue number(s) with a closing keyword: "Fixes #ISSUE-NUMBER".

@algorithms-keeper algorithms-keeper bot added enhancement This PR modified some existing files awaiting reviews This PR is ready to be reviewed labels Aug 14, 2023
@CaedenPH
Copy link
Contributor Author

@tianyizheng02 What is your opinion of merging the recursive and iterative implementations into one file?

Could also add benchmarks to compare the difference in time complexity between the implementations

@tianyizheng02
Copy link
Contributor

I support these kinds of file merges. Like you said, it helps with benchmarking, but it also just makes it much easier to compare different implementations in general

Also helps with resolving #8098, of course

tianyizheng02
tianyizheng02 requested changes Aug 14, 2023
View reviewed changes
maths/find_max.py
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Now that this file also contains the recursive implementation, we should probably rename the existing find_max to find_max_iterative to contrast it with the recursive one.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good idea

maths/find_min.py
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

find_min() -> find_min_iterative() (see previous comment)

@tianyizheng02 tianyizheng02 merged commit fb1b939 into TheAlgorithms:master Aug 14, 2023
@algorithms-keeper algorithms-keeper bot removed the awaiting reviews This PR is ready to be reviewed label Aug 14, 2023
@CaedenPH CaedenPH deleted the consolidate-min-max branch August 14, 2023 11:19
sedatguzelsemme pushed a commit to sedatguzelsemme/Python that referenced this pull request Sep 15, 2024
@CaedenPH @sedatguzelsemme
Consolidate find_min and find_min recursive and find_max and find_max…
68e49cf 
…_recursive (TheAlgorithms#8960)

* updating DIRECTORY.md

* refactor(min-max): Consolidate implementations

* updating DIRECTORY.md

* refactor(min-max): Append _iterative to func name

---------

Co-authored-by: github-actions <${GITHUB_ACTOR}@users.noreply.github.com>
@isidroas isidroas mentioned this pull request Jan 25, 2025
Closed
14 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tianyizheng02 tianyizheng02 tianyizheng02 approved these changes

Assignees
No one assigned
Labels
enhancement This PR modified some existing files
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@CaedenPH @tianyizheng02