Skip to content

Remove a slash in path to save the file correctly on Linux #8053

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 15, 2023
Merged

Remove a slash in path to save the file correctly on Linux #8053

merged 1 commit into from
Aug 15, 2023

Conversation

Erfaniaa
Copy link
Member

Describe your change:

  • Add an algorithm?
  • Fix a bug or typo in an existing algorithm?
  • Documentation change?

Checklist:

  • I have read CONTRIBUTING.md.
  • This pull request is all my own work -- I have not plagiarized.
  • I know that pull requests will not be merged if they fail the automated tests.
  • This PR only changes one algorithm file. To ease review, please open separate PRs for separate algorithms.
  • All new Python files are placed inside an existing directory.
  • All filenames are in all lowercase characters with no spaces or dashes.
  • All functions and variable names follow Python naming conventions.
  • All function parameters and return values are annotated with Python type hints.
  • All functions have doctests that pass the automated testing.
  • All new algorithms include at least one URL that points to Wikipedia or another similar explanation.
  • If this pull request resolves one or more open issues then the commit message contains Fixes: #{$ISSUE_NO}.

@algorithms-keeper algorithms-keeper bot added awaiting reviews This PR is ready to be reviewed enhancement This PR modified some existing files labels Dec 27, 2022
CaedenPH
CaedenPH approved these changes Dec 27, 2022
View reviewed changes
Copy link
Contributor

@CaedenPH CaedenPH left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good - Great spot

CaedenPH
CaedenPH approved these changes Dec 27, 2022
View reviewed changes
Copy link
Contributor

@CaedenPH CaedenPH left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good - Great spot

itsamirhn
itsamirhn reviewed Dec 27, 2022
View reviewed changes
computer_vision/flip_augmentation.py
@@ -32,13 +32,13 @@ def main() -> None:
letter_code = random_chars(32)
file_name = paths[index].split(os.sep)[-1].rsplit(".", 1)[0]
file_root = f"{OUTPUT_DIR}/{file_name}_FLIP_{letter_code}"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
file_root = f"{OUTPUT_DIR}/{file_name}_FLIP_{letter_code}"
file_root = os.path.join(OUTPUT_DIR, f"{file_name}_FLIP_{letter_code}")

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we use pathlib instead?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
file_root = f"{OUTPUT_DIR}/{file_name}_FLIP_{letter_code}"
file_root = Path(OUTPUT_DIR, f"{file_name}_FLIP_{letter_code}")

tianyizheng02
tianyizheng02 previously requested changes Aug 13, 2023
View reviewed changes
computer_vision/flip_augmentation.py
@@ -32,13 +32,13 @@ def main() -> None:
letter_code = random_chars(32)
file_name = paths[index].split(os.sep)[-1].rsplit(".", 1)[0]
file_root = f"{OUTPUT_DIR}/{file_name}_FLIP_{letter_code}"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
file_root = f"{OUTPUT_DIR}/{file_name}_FLIP_{letter_code}"
file_root = Path(OUTPUT_DIR, f"{file_name}_FLIP_{letter_code}")

@cclauss cclauss enabled auto-merge (squash) August 15, 2023 20:37
@cclauss cclauss merged commit 7618a92 into TheAlgorithms:master Aug 15, 2023
@algorithms-keeper algorithms-keeper bot removed the awaiting reviews This PR is ready to be reviewed label Aug 15, 2023
sedatguzelsemme pushed a commit to sedatguzelsemme/Python that referenced this pull request Sep 15, 2024
@Erfaniaa @sedatguzelsemme
Remove a slash in path to save the file correctly on Linux (TheAlgori…
1db49da 
…thms#8053)
@isidroas isidroas mentioned this pull request Jan 25, 2025
Closed
14 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@itsamirhn itsamirhn itsamirhn left review comments

@cclauss cclauss cclauss approved these changes

@CaedenPH CaedenPH CaedenPH approved these changes

@tianyizheng02 tianyizheng02 tianyizheng02 left review comments

Assignees
No one assigned
Labels
enhancement This PR modified some existing files
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@Erfaniaa @cclauss @itsamirhn @CaedenPH @tianyizheng02