Skip to content

Reduce the complexity of sorts/merge_insertion_sort.py #7954

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Dec 24, 2022
Merged

Reduce the complexity of sorts/merge_insertion_sort.py #7954

merged 4 commits into from
Dec 24, 2022

Conversation

MaximSmolskiy
Copy link
Member

Describe your change:

Reduce the complexity of sorts/merge_insertion sort.py from 19 to 9

  • Add an algorithm?
  • Fix a bug or typo in an existing algorithm?
  • Documentation change?

Checklist:

  • I have read CONTRIBUTING.md.
  • This pull request is all my own work -- I have not plagiarized.
  • I know that pull requests will not be merged if they fail the automated tests.
  • This PR only changes one algorithm file. To ease review, please open separate PRs for separate algorithms.
  • All new Python files are placed inside an existing directory.
  • All filenames are in all lowercase characters with no spaces or dashes.
  • All functions and variable names follow Python naming conventions.
  • All function parameters and return values are annotated with Python type hints.
  • All functions have doctests that pass the automated testing.
  • All new algorithms include at least one URL that points to Wikipedia or another similar explanation.
  • If this pull request resolves one or more open issues then the commit message contains Fixes: #{$ISSUE_NO}.

@algorithms-keeper algorithms-keeper bot added enhancement This PR modified some existing files awaiting reviews This PR is ready to be reviewed labels Nov 2, 2022
@MaximSmolskiy MaximSmolskiy changed the title Reduce the complexity of sorts/merge_insertion sort.py Reduce the complexity of sorts/merge_insertion_sort.py Nov 3, 2022
@MaximSmolskiy
Copy link
Member Author

@cclauss please review

2 similar comments
@MaximSmolskiy
Copy link
Member Author

@cclauss please review

@MaximSmolskiy
Copy link
Member Author

@cclauss please review

@algorithms-keeper algorithms-keeper bot removed the awaiting reviews This PR is ready to be reviewed label Dec 24, 2022
@cclauss cclauss merged commit 79ef431 into TheAlgorithms:master Dec 24, 2022
@MaximSmolskiy MaximSmolskiy deleted the reduce-the-complexity-of-sorts/merge_insertion_sort.py branch December 24, 2022 15:01
@MaximSmolskiy MaximSmolskiy mentioned this pull request Dec 24, 2022
Merged
14 tasks
Cjkjvfnby pushed a commit to Cjkjvfnby/Python that referenced this pull request Mar 13, 2023
@MaximSmolskiy @Cjkjvfnby
Reduce the complexity of sorts/merge_insertion_sort.py (TheAlgorithms…
d7df6d6 
…#7954)

* Reduce the complexity of sorts/merge_insertion_sort.py

* Add tests

* Lower the --max-complexity threshold in the file .flake8
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cclauss cclauss cclauss approved these changes

@dhruvmanila dhruvmanila Awaiting requested review from dhruvmanila

Assignees
No one assigned
Labels
enhancement This PR modified some existing files
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@MaximSmolskiy @cclauss