Skip to content

Add Catalan number to maths #6845

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Oct 8, 2022
Merged

Add Catalan number to maths #6845

merged 3 commits into from
Oct 8, 2022
+54 −1

Conversation

jrinder42
Copy link
Contributor

Describe your change:

  • Add an algorithm?
  • Fix a bug or typo in an existing algorithm?
  • Documentation change?

Checklist:

  • I have read CONTRIBUTING.md.
  • This pull request is all my own work -- I have not plagiarized.
  • I know that pull requests will not be merged if they fail the automated tests.
  • This PR only changes one algorithm file. To ease review, please open separate PRs for separate algorithms.
  • All new Python files are placed inside an existing directory.
  • All filenames are in all lowercase characters with no spaces or dashes.
  • All functions and variable names follow Python naming conventions.
  • All function parameters and return values are annotated with Python type hints.
  • All functions have doctests that pass the automated testing.
  • All new algorithms have a URL in its comments that points to Wikipedia or other similar explanation.
  • If this pull request resolves one or more open issues then the commit message contains Fixes: #{$ISSUE_NO}.

@jrinder42 jrinder42 requested a review from Kush1101 as a code owner October 8, 2022 20:42
@algorithms-keeper algorithms-keeper bot added the awaiting reviews This PR is ready to be reviewed label Oct 8, 2022
poyea
poyea reviewed Oct 8, 2022
View reviewed changes
Copy link
Member

@poyea poyea left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will there be 2 catalan_number now? https://github.com/TheAlgorithms/Python/blob/master/dynamic_programming/catalan_numbers.py

@jrinder42
Copy link
Contributor Author

Will there be 2 catalan_number now? https://github.com/TheAlgorithms/Python/blob/master/dynamic_programming/catalan_numbers.py

It should be fine given this approach does not use dynamic programming. There are many variations of generating these types of numbers.

poyea
poyea approved these changes Oct 8, 2022
View reviewed changes
Copy link
Member

@poyea poyea left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your pull request!🤩

@poyea poyea merged commit 5894554 into TheAlgorithms:master Oct 8, 2022
@algorithms-keeper algorithms-keeper bot removed awaiting reviews This PR is ready to be reviewed labels Oct 8, 2022
@jrinder42 jrinder42 deleted the catalan_number branch October 8, 2022 23:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@poyea poyea poyea approved these changes

@Kush1101 Kush1101 Awaiting requested review from Kush1101

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jrinder42 @poyea