There is an invalid case also in Knapsack. #4911
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ase add this invalid case where input is worng (when length of weight and value is not equal)
ghost
added
awaiting reviews
PzaThief
suggested changes
Oct 2, 2021
| @@ -20,6 +20,10 @@ def knapsack(capacity: int, weights: list[int], values: list[int], counter: int) | |||
| which is the limit of the capacity. | |||
| """ | |||
|
|
|||
| # Invalid Case | |||
| if len(val)!=len(w): | |||
There was a problem hiding this comment.
please recheck the variable name.
There was a problem hiding this comment.
How do i do that now. Can you please suggest me. Should i create new PR or what. Really new here
There was a problem hiding this comment.
as you can see if knapsack called like knapsack(cap, w, val, c) then knapsack function accept the variables to named capacity, weights, values and counter.
so, there is no val and w now but only use values and weights.
then now you can code like this -> if len(values) != len(weights)
|
Hey. I previously didn't knew about branching. So, this time I created a new branch for pull request here #4956 Please apologize for any inconvenience |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Many people ignore it. Please add this invalid case where input is worng (when length of weight and value is not equal)
Describe your change:
There is invalid case in knapsack. Many people ignore it. I have included that case in knapsack.py
Invalid case is a case where weight and value array is not of equal length
Therefore I added - if len(w)!=len(val): return -1
I have returned -1 because otherwise user will not get to know that input was wrong.
If I would have returned 0, user would think, there is no space in bag to accept least weight.
Checklist:
Fixes: #{$ISSUE_NO}.