Skip to content

[mypy] Fix type annotations for cellular_automata #4236

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
Mar 20, 2021
Merged

[mypy] Fix type annotations for cellular_automata #4236

merged 6 commits into from
Mar 20, 2021

Conversation

noviicee
Copy link
Contributor

Describe your change:

  • Add an algorithm?
  • Fix a bug or typo in an existing algorithm?
  • Documentation change?

Checklist:

  • I have read CONTRIBUTING.md.
  • This pull request is all my own work -- I have not plagiarized.
  • I know that pull requests will not be merged if they fail the automated tests.
  • This PR only changes one algorithm file. To ease review, please open separate PRs for separate algorithms.
  • All new Python files are placed inside an existing directory.
  • All filenames are in all lowercase characters with no spaces or dashes.
  • All functions and variable names follow Python naming conventions.
  • All function parameters and return values are annotated with Python type hints.
  • All functions have doctests that pass the automated testing.
  • All new algorithms have a URL in its comments that points to Wikipedia or other similar explanation.
  • If this pull request resolves one or more open issues then the commit message contains Fixes: #{$ISSUE_NO}.

@ghost ghost added merge conflicts Open a new PR or rebase on the latest commit enhancement This PR modified some existing files awaiting reviews This PR is ready to be reviewed labels Feb 24, 2021
@noviicee
Copy link
Contributor Author

Hey I don't know how this happened but when I cloned it in my local machine, the #type: ignore was not present.
It is still not showing on my local machine and mypy . is giving errors for the corresponding file.
Can anybody please help me up with this one?

@ghost ghost removed the merge conflicts Open a new PR or rebase on the latest commit label Feb 24, 2021
@noviicee
Copy link
Contributor Author

Hey I don't know how this happened but when I cloned it in my local machine, the #type: ignore was not present.
It is still not showing on my local machine and mypy . is giving errors for the corresponding file.
Can anybody please help me up with this one?

It has been resolved now :)

@ghost ghost added the tests are failing Do not merge until tests pass label Feb 24, 2021
@ghost ghost removed the awaiting reviews This PR is ready to be reviewed label Mar 20, 2021
@ghost ghost added the awaiting reviews This PR is ready to be reviewed label Mar 20, 2021
@ghost ghost removed the tests are failing Do not merge until tests pass label Mar 20, 2021
@cclauss
Copy link
Member

cclauss commented Mar 20, 2021

Please run mypy --ignore-missing-imports . instead of mypy .

@ghost ghost removed the awaiting reviews This PR is ready to be reviewed label Mar 20, 2021
@cclauss cclauss merged commit 2c6f553 into TheAlgorithms:master Mar 20, 2021
peRFectBeliever pushed a commit to peRFectBeliever/Python that referenced this pull request Apr 1, 2021
@noviicee @cclauss @peRFectBeliever
[mypy] Fix type annotations for cellular_automata (TheAlgorithms#4236)
bc06b6d 
* [mypy] Fix type annotations for cellullar_automata

* mypy --ignore-missing-imports

* mypy --ignore-missing-imports

* Blank lines

* Blank lines

Co-authored-by: Christian Clauss <[email protected]>
@noviicee noviicee deleted the mypy-fix-novice branch April 18, 2021 17:39
Panquesito7 pushed a commit to Panquesito7/Python that referenced this pull request May 13, 2021
@noviicee @cclauss
[mypy] Fix type annotations for cellular_automata (TheAlgorithms#4236)
d2a033c 
* [mypy] Fix type annotations for cellullar_automata

* mypy --ignore-missing-imports

* mypy --ignore-missing-imports

* Blank lines

* Blank lines

Co-authored-by: Christian Clauss <[email protected]>
shermanhui pushed a commit to shermanhui/Python that referenced this pull request Oct 22, 2021
@noviicee @cclauss @shermanhui
[mypy] Fix type annotations for cellular_automata (TheAlgorithms#4236)
56463d2 
* [mypy] Fix type annotations for cellullar_automata

* mypy --ignore-missing-imports

* mypy --ignore-missing-imports

* Blank lines

* Blank lines

Co-authored-by: Christian Clauss <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cclauss cclauss cclauss approved these changes

Assignees
No one assigned
Labels
enhancement This PR modified some existing files
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@noviicee @cclauss