Skip to content

[mypy] Add/fix type annotations for quick_sort(#4085) #4215

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Feb 20, 2021
Merged

[mypy] Add/fix type annotations for quick_sort(#4085) #4215

merged 1 commit into from
Feb 20, 2021

Conversation

MatthewG25
Copy link
Contributor

Describe your change:

Adding type annotations for the greater and lesser list types in the algorithm

Checklist:

  • [x ] I have read CONTRIBUTING.md.
  • [x ] This pull request is all my own work -- I have not plagiarized.
  • [x ] I know that pull requests will not be merged if they fail the automated tests.
  • [x ] This PR only changes one algorithm file. To ease review, please open separate PRs for separate algorithms.
  • [x ] All new Python files are placed inside an existing directory.
  • [x ] All filenames are in all lowercase characters with no spaces or dashes.
  • [x ] All functions and variable names follow Python naming conventions.
  • All function parameters and return values are annotated with Python type hints.
  • [x ] All functions have doctests that pass the automated testing.
  • [x ] All new algorithms have a URL in its comments that points to Wikipedia or other similar explanation.
  • If this pull request resolves one or more open issues then the commit message contains Fixes: #{$ISSUE_NO}.

@ghost ghost added enhancement This PR modified some existing files awaiting reviews This PR is ready to be reviewed labels Feb 20, 2021
@MatthewG25
Copy link
Contributor Author

MatthewG25 commented Feb 20, 2021 •
edited
Loading

Can i confirm that any small changes have to be in seperate pull requests or can they be clumped together? If so if I will update this pull request with the other changes that I have made tomorrow evening GMT time.

@ghost ghost removed the awaiting reviews This PR is ready to be reviewed label Feb 20, 2021
@l3str4nge l3str4nge merged commit 81c46df into TheAlgorithms:master Feb 20, 2021
peRFectBeliever pushed a commit to peRFectBeliever/Python that referenced this pull request Apr 1, 2021
@MatthewG25 @peRFectBeliever
[mypy] Add/fix type annotations for quick_sort(TheAlgorithms#4085) (T…
2a7351e 
…heAlgorithms#4215)

Co-authored-by: goodm2 <4qjpngu8mem8cz>
Panquesito7 pushed a commit to Panquesito7/Python that referenced this pull request May 13, 2021
@MatthewG25
[mypy] Add/fix type annotations for quick_sort(TheAlgorithms#4085) (T…
ed33b1e 
…heAlgorithms#4215)

Co-authored-by: goodm2 <4qjpngu8mem8cz>
shermanhui pushed a commit to shermanhui/Python that referenced this pull request Oct 22, 2021
@MatthewG25 @shermanhui
[mypy] Add/fix type annotations for quick_sort(TheAlgorithms#4085) (T…
ae0a9f5 
…heAlgorithms#4215)

Co-authored-by: goodm2 <4qjpngu8mem8cz>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@l3str4nge l3str4nge l3str4nge approved these changes

Assignees
No one assigned
Labels
enhancement This PR modified some existing files
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@MatthewG25 @l3str4nge