Skip to content

[mypy] Add/fix type annotations for hashes. Fix for binary_tree_traversals #4143

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 5 commits into from
Closed

[mypy] Add/fix type annotations for hashes. Fix for binary_tree_traversals #4143

wants to merge 5 commits into from

Conversation

barklan
Copy link

@barklan barklan commented Jan 24, 2021 •
edited
Loading

Describe your change:

Related Issue: #4052
Fix incorrect confusing type annotations in hashes

  • Add an algorithm?
  • Fix a bug or typo in an existing algorithm?
  • Documentation change?

Checklist:

  • I have read CONTRIBUTING.md.
  • This pull request is all my own work -- I have not plagiarized.
  • I know that pull requests will not be merged if they fail the automated tests.
  • This PR only changes one algorithm file. To ease review, please open separate PRs for separate algorithms.
  • All new Python files are placed inside an existing directory.
  • All filenames are in all lowercase characters with no spaces or dashes.
  • All functions and variable names follow Python naming conventions.
  • All function parameters and return values are annotated with Python type hints.
  • All functions have doctests that pass the automated testing.
  • All new algorithms have a URL in its comments that points to Wikipedia or other similar explanation.
  • If this pull request resolves one or more open issues then the commit message contains Fixes: #{$ISSUE_NO}.

@ghost ghost added enhancement This PR modified some existing files awaiting reviews This PR is ready to be reviewed labels Jan 24, 2021
@barklan barklan changed the title Mypy fix [mypy] Add/fix type annotations for hashes. Fix for binary_tree_traversals Jan 24, 2021
poyea
poyea reviewed Feb 4, 2021
View reviewed changes
dhruvmanila
dhruvmanila requested changes Feb 23, 2021
View reviewed changes
Copy link
Member

@dhruvmanila dhruvmanila left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @barklan, did you run mypy locally because running it on my machine yields a lot of errors in some of the files. Can you take a look into them? You will have to install mypy and the required imports, if there are any in all the pull request files.

@ghost ghost added awaiting changes A maintainer has requested changes to this PR and removed awaiting reviews This PR is ready to be reviewed labels Feb 23, 2021
@stale
Copy link

stale bot commented Mar 26, 2021

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the stale Used to mark an issue or pull request stale. label Mar 26, 2021
@cclauss
Copy link
Member

cclauss commented Apr 28, 2021

This work was done in other pull requests.

@cclauss cclauss closed this Apr 28, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@poyea poyea poyea left review comments

@mrmaxguns mrmaxguns mrmaxguns left review comments

@dhruvmanila dhruvmanila dhruvmanila requested changes

Assignees
No one assigned
Labels
awaiting changes A maintainer has requested changes to this PR enhancement This PR modified some existing files stale Used to mark an issue or pull request stale.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@barklan @cclauss @poyea @mrmaxguns @dhruvmanila