From fe5160ff7fbfdc5f7a278074f297737e7b783610 Mon Sep 17 00:00:00 2001 From: SteveKimSR Date: Sat, 2 Jan 2021 01:50:42 +0900 Subject: [PATCH 1/4] [mypy] Add/fix type annotations for similarity search in machine learning --- machine_learning/similarity_search.py | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/machine_learning/similarity_search.py b/machine_learning/similarity_search.py index 6bfb12ed88cb..0722bc374adb 100644 --- a/machine_learning/similarity_search.py +++ b/machine_learning/similarity_search.py @@ -8,6 +8,7 @@ 2. distance between the vector and the nearest vector (float) """ import math +from typing import List import numpy as np @@ -30,7 +31,9 @@ def euclidean(input_a: np.ndarray, input_b: np.ndarray) -> float: return math.sqrt(sum(pow(a - b, 2) for a, b in zip(input_a, input_b))) -def similarity_search(dataset: np.ndarray, value_array: np.ndarray) -> list: +def similarity_search( + dataset: np.ndarray, value_array: np.ndarray +) -> List[List[float]]: """ :param dataset: Set containing the vectors. Should be ndarray. :param value_array: vector/vectors we want to know the nearest vector from dataset. From ba94f1188bde37ce94ca5da939593037c12b8118 Mon Sep 17 00:00:00 2001 From: SteveKimSR Date: Wed, 6 Jan 2021 20:13:07 +0900 Subject: [PATCH 2/4] fix annotation --- machine_learning/similarity_search.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/machine_learning/similarity_search.py b/machine_learning/similarity_search.py index 0722bc374adb..f4e22a8a119e 100644 --- a/machine_learning/similarity_search.py +++ b/machine_learning/similarity_search.py @@ -33,7 +33,7 @@ def euclidean(input_a: np.ndarray, input_b: np.ndarray) -> float: def similarity_search( dataset: np.ndarray, value_array: np.ndarray -) -> List[List[float]]: +) -> List[List[List[float], float]]: """ :param dataset: Set containing the vectors. Should be ndarray. :param value_array: vector/vectors we want to know the nearest vector from dataset. From 68fe17349fed6c3d8540c4d97898bd4e4db122f7 Mon Sep 17 00:00:00 2001 From: SteveKimSR Date: Wed, 6 Jan 2021 21:17:15 +0900 Subject: [PATCH 3/4] fix annotation (Union) --- machine_learning/similarity_search.py | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/machine_learning/similarity_search.py b/machine_learning/similarity_search.py index f4e22a8a119e..fc6282ff720f 100644 --- a/machine_learning/similarity_search.py +++ b/machine_learning/similarity_search.py @@ -8,8 +8,7 @@ 2. distance between the vector and the nearest vector (float) """ import math -from typing import List - +from typing import List, Union import numpy as np @@ -33,7 +32,7 @@ def euclidean(input_a: np.ndarray, input_b: np.ndarray) -> float: def similarity_search( dataset: np.ndarray, value_array: np.ndarray -) -> List[List[List[float], float]]: +) -> List[List[Union[List[float], float]]]: """ :param dataset: Set containing the vectors. Should be ndarray. :param value_array: vector/vectors we want to know the nearest vector from dataset. From e95bb278cd8dcd486897a1072f3cae2afbf225b8 Mon Sep 17 00:00:00 2001 From: SteveKimSR Date: Wed, 6 Jan 2021 22:17:43 +0900 Subject: [PATCH 4/4] isort --- machine_learning/similarity_search.py | 1 + 1 file changed, 1 insertion(+) diff --git a/machine_learning/similarity_search.py b/machine_learning/similarity_search.py index fc6282ff720f..af845c9109b1 100644 --- a/machine_learning/similarity_search.py +++ b/machine_learning/similarity_search.py @@ -9,6 +9,7 @@ """ import math from typing import List, Union + import numpy as np