Replace base64_cipher.py with an easy to understand version #3925
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
added
awaiting reviews
ghost
added
awaiting reviews
15 tasks
amaank404
approved these changes
Nov 23, 2020
|
@cclauss, check this |
cclauss
requested changes
Nov 25, 2020
ghost
added
awaiting changes
cclauss
reviewed
Nov 25, 2020
cclauss
reviewed
Nov 25, 2020
cclauss
reviewed
Nov 25, 2020
Co-authored-by: Christian Clauss <[email protected]>
cclauss
approved these changes
Nov 25, 2020
stokhos
pushed a commit
to stokhos/Python
that referenced
this pull request
Jan 3, 2021
…ithms#3925) * rename base64_cipher.py to base64_encoding.py * edit base64_encoding.py * import necessary modules inside doctests * make it behave like the official implementation * replace format with f-string where possible * replace format with f-string Co-authored-by: Christian Clauss <[email protected]> * fix: syntax error due to closing parenthese * reformat code Co-authored-by: Christian Clauss <[email protected]>
peRFectBeliever
pushed a commit
to peRFectBeliever/Python
that referenced
this pull request
Apr 1, 2021
…ithms#3925) * rename base64_cipher.py to base64_encoding.py * edit base64_encoding.py * import necessary modules inside doctests * make it behave like the official implementation * replace format with f-string where possible * replace format with f-string Co-authored-by: Christian Clauss <[email protected]> * fix: syntax error due to closing parenthese * reformat code Co-authored-by: Christian Clauss <[email protected]>
Panquesito7
pushed a commit
to Panquesito7/Python
that referenced
this pull request
May 13, 2021
…ithms#3925) * rename base64_cipher.py to base64_encoding.py * edit base64_encoding.py * import necessary modules inside doctests * make it behave like the official implementation * replace format with f-string where possible * replace format with f-string Co-authored-by: Christian Clauss <[email protected]> * fix: syntax error due to closing parenthese * reformat code Co-authored-by: Christian Clauss <[email protected]>
shermanhui
pushed a commit
to shermanhui/Python
that referenced
this pull request
Oct 22, 2021
…ithms#3925) * rename base64_cipher.py to base64_encoding.py * edit base64_encoding.py * import necessary modules inside doctests * make it behave like the official implementation * replace format with f-string where possible * replace format with f-string Co-authored-by: Christian Clauss <[email protected]> * fix: syntax error due to closing parenthese * reformat code Co-authored-by: Christian Clauss <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your change:
This PR changes the existing
base64_cipher.pywith an easy to understand script that explains how the Base64 algorithm works under the hood. The solution is not necessarily faster, but I believe it will help people understand how the algorithm works and why it is possible to use Base64 in Steganography to conceal the existence of a piece of data.Further more, I believe the
base64_cipher.pyname can be misleading as Base64 is considered an encoding, and not a cipher.Checklist:
Fixes: #{$ISSUE_NO}.