Skip to content

Update CONTRIBUTING.md #3698

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Oct 26, 2020
Merged

Update CONTRIBUTING.md #3698

merged 4 commits into from
Oct 26, 2020

Conversation

amaank404
Copy link
Contributor

Needed to tell people so we do not receive any duplicate solution. Do not count this as hactoberfest-accepted

Describe your change:

  • Add an algorithm?
  • Fix a bug or typo in an existing algorithm?
  • Documentation change?

Checklist:

  • I have read CONTRIBUTING.md.
  • This pull request is all my own work -- I have not plagiarized.
  • I know that pull requests will not be merged if they fail the automated tests.
  • This PR only changes one algorithm file. To ease review, please open separate PRs for separate algorithms.
  • All new Python files are placed inside an existing directory.
  • All filenames are in all lowercase characters with no spaces or dashes.
  • All functions and variable names follow Python naming conventions.
  • All function parameters and return values are annotated with Python type hints.
  • All functions have doctests that pass the automated testing.
  • All new algorithms have a URL in its comments that points to Wikipedia or other similar explanation.
  • If this pull request resolves one or more open issues then the commit message contains Fixes: #{$ISSUE_NO}.

@amaank404
Update CONTRIBUTING.md
5f5debf 
Needed to tell people so we do not receive any duplicate solution. Do not count this as hactoberfest-accepted
@amaank404 amaank404 marked this pull request as ready for review October 24, 2020 07:45
@amaank404
Copy link
Contributor Author

@dhruvmanila @poyea, check this (ready to merge)

poyea
poyea approved these changes Oct 24, 2020
View reviewed changes
Copy link
Member

@poyea poyea left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You may bold same implementation. Let's wait for possibly one more approval. Thanks.

amaank404
amaank404 commented Oct 24, 2020
View reviewed changes
realDuYuanChao
realDuYuanChao reviewed Oct 24, 2020
View reviewed changes
@amaank404 @realDuYuanChao
Update CONTRIBUTING.md
9241e20 
typo fix

Co-authored-by: Du Yuanchao <[email protected]>
@amaank404
Copy link
Contributor Author

@shellhub check this out

@poyea poyea merged commit 47199c1 into TheAlgorithms:master Oct 26, 2020
@TravisBuddy
Copy link

Hey @xcodz-dot,
Something went wrong with the build.

TravisCI finished with status errored, which means the build failed because of something unrelated to the tests, such as a problem with a dependency or the build process itself.

View build log

TravisBuddy Request Identifier: 9ea514d0-1755-11eb-9e63-49d4a1c7c4f7

@amaank404 amaank404 deleted the patch-1 branch October 27, 2020 09:25
stokhos pushed a commit to stokhos/Python that referenced this pull request Jan 3, 2021
@amaank404 @realDuYuanChao
@poyea @stokhos
Update CONTRIBUTING.md (TheAlgorithms#3698)
9116bfd 
* Update CONTRIBUTING.md

Needed to tell people so we do not receive any duplicate solution. Do not count this as hactoberfest-accepted

* Update CONTRIBUTING.md

* Update CONTRIBUTING.md

typo fix

Co-authored-by: Du Yuanchao <[email protected]>

* Update CONTRIBUTING.md

Co-authored-by: Du Yuanchao <[email protected]>
Co-authored-by: John Law <[email protected]>
peRFectBeliever pushed a commit to peRFectBeliever/Python that referenced this pull request Apr 1, 2021
@amaank404 @realDuYuanChao
@poyea @peRFectBeliever
Update CONTRIBUTING.md (TheAlgorithms#3698)
2ac6391 
* Update CONTRIBUTING.md

Needed to tell people so we do not receive any duplicate solution. Do not count this as hactoberfest-accepted

* Update CONTRIBUTING.md

* Update CONTRIBUTING.md

typo fix

Co-authored-by: Du Yuanchao <[email protected]>

* Update CONTRIBUTING.md

Co-authored-by: Du Yuanchao <[email protected]>
Co-authored-by: John Law <[email protected]>
Panquesito7 pushed a commit to Panquesito7/Python that referenced this pull request May 13, 2021
@amaank404 @realDuYuanChao @poyea
Update CONTRIBUTING.md (TheAlgorithms#3698)
13672c1 
* Update CONTRIBUTING.md

Needed to tell people so we do not receive any duplicate solution. Do not count this as hactoberfest-accepted

* Update CONTRIBUTING.md

* Update CONTRIBUTING.md

typo fix

Co-authored-by: Du Yuanchao <[email protected]>

* Update CONTRIBUTING.md

Co-authored-by: Du Yuanchao <[email protected]>
Co-authored-by: John Law <[email protected]>
shermanhui pushed a commit to shermanhui/Python that referenced this pull request Oct 22, 2021
@amaank404 @realDuYuanChao
@poyea @shermanhui
Update CONTRIBUTING.md (TheAlgorithms#3698)
3c1bf15 
* Update CONTRIBUTING.md

Needed to tell people so we do not receive any duplicate solution. Do not count this as hactoberfest-accepted

* Update CONTRIBUTING.md

* Update CONTRIBUTING.md

typo fix

Co-authored-by: Du Yuanchao <[email protected]>

* Update CONTRIBUTING.md

Co-authored-by: Du Yuanchao <[email protected]>
Co-authored-by: John Law <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@realDuYuanChao realDuYuanChao realDuYuanChao left review comments

@poyea poyea poyea approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@amaank404 @TravisBuddy @poyea @realDuYuanChao