Skip to content

Add Patience Sort #3469

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 9 commits into from
Oct 18, 2020
Merged

Add Patience Sort #3469

merged 9 commits into from
Oct 18, 2020

Conversation

JoaoVictorNascimento
Copy link
Contributor

@JoaoVictorNascimento JoaoVictorNascimento commented Oct 18, 2020 •
edited
Loading

Describe your change:

  • Add an algorithm?
  • Fix a bug or typo in an existing algorithm?
  • Documentation change?

Checklist:

  • I have read CONTRIBUTING.md.
  • This pull request is all my own work -- I have not plagiarized.
  • I know that pull requests will not be merged if they fail the automated tests.
  • This PR only changes one algorithm file. To ease review, please open separate PRs for separate algorithms.
  • All new Python files are placed inside an existing directory.
  • All filenames are in all lowercase characters with no spaces or dashes.
  • All functions and variable names follow Python naming conventions.
  • All function parameters and return values are annotated with Python type hints.
  • All functions have doctests that pass the automated testing.
  • All new algorithms have a URL in its comments that points to Wikipedia or other similar explanation.
  • If this pull request resolves one or more open issues then the commit message contains Fixes: #{$ISSUE_NO}.

@TravisBuddy
Copy link

Travis tests have failed

Hey @JoaoVictorNascimento,
Please read the following log in order to understand the failure reason.
It'll be awesome if you fix what's wrong and commit the changes.

TravisBuddy Request Identifier: 682f2050-10eb-11eb-af89-615b230ba186

@JoaoVictorNascimento
Copy link
Contributor Author

@mateuszz0000 could you review my pull request?

l3str4nge
l3str4nge requested changes Oct 18, 2020
View reviewed changes
sorts/patience_sort.py
from functools import total_ordering
from heapq import merge

"""
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please provide some url for theory

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added

l3str4nge
l3str4nge approved these changes Oct 18, 2020
View reviewed changes
Copy link
Member

@l3str4nge l3str4nge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! Well done :)

@l3str4nge l3str4nge merged commit 79d5755 into TheAlgorithms:master Oct 18, 2020
@JoaoVictorNascimento
Copy link
Contributor Author

Thanks @mateuszz0000! Could you put the hacktoberfest-accepted label?

@l3str4nge l3str4nge added the hacktoberfest-accepted Accepted to be counted towards Hacktoberfest label Oct 18, 2020
stokhos pushed a commit to stokhos/Python that referenced this pull request Jan 3, 2021
@JoaoVictorNascimento @JimmyRaper @stokhos
Add Patience Sort (TheAlgorithms#3469)
625c843 
* Add Patience Sort

* fix code for pre-commit

* Fix params def

* Adding new line at end of file

* Remove Trailing Whitespace

* Adding space between the methods of the Stack class

* Removing Trailing Whitespace

* Ordering Imports

* Adding url patience sort

Co-authored-by: jvnascimento <[email protected]>
peRFectBeliever pushed a commit to peRFectBeliever/Python that referenced this pull request Apr 1, 2021
@JoaoVictorNascimento @JimmyRaper @peRFectBeliever
Add Patience Sort (TheAlgorithms#3469)
ced2cf5 
* Add Patience Sort

* fix code for pre-commit

* Fix params def

* Adding new line at end of file

* Remove Trailing Whitespace

* Adding space between the methods of the Stack class

* Removing Trailing Whitespace

* Ordering Imports

* Adding url patience sort

Co-authored-by: jvnascimento <[email protected]>
Panquesito7 pushed a commit to Panquesito7/Python that referenced this pull request May 13, 2021
@JoaoVictorNascimento @JimmyRaper
Add Patience Sort (TheAlgorithms#3469)
12aae04 
* Add Patience Sort

* fix code for pre-commit

* Fix params def

* Adding new line at end of file

* Remove Trailing Whitespace

* Adding space between the methods of the Stack class

* Removing Trailing Whitespace

* Ordering Imports

* Adding url patience sort

Co-authored-by: jvnascimento <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@l3str4nge l3str4nge l3str4nge approved these changes

Assignees
No one assigned
Labels
hacktoberfest-accepted Accepted to be counted towards Hacktoberfest
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@JoaoVictorNascimento @TravisBuddy @l3str4nge @JimmyRaper