Skip to content

Add Qiskit Quantum NOT Gate Example Code #3255

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Oct 13, 2020
Merged

Add Qiskit Quantum NOT Gate Example Code #3255

merged 2 commits into from
Oct 13, 2020

Conversation

abhishekjiitr
Copy link
Contributor

@abhishekjiitr abhishekjiitr commented Oct 13, 2020 •
edited
Loading

Describe your change:

  • Add an algorithm?
  • Fix a bug or typo in an existing algorithm?
  • Documentation change?

Checklist:

  • I have read CONTRIBUTING.md.
  • This pull request is all my own work -- I have not plagiarized.
  • I know that pull requests will not be merged if they fail the automated tests.
  • This PR only changes one algorithm file. To ease review, please open separate PRs for separate algorithms.
  • All new Python files are placed inside an existing directory.
  • All filenames are in all lowercase characters with no spaces or dashes.
  • All functions and variable names follow Python naming conventions.
  • All function parameters and return values are annotated with Python type hints.
  • All functions have doctests that pass the automated testing.
  • All new algorithms have a URL in its comments that points to Wikipedia or other similar explanation.
  • If this pull request resolves one or more open issues then the commit message contains Fixes: #{$ISSUE_NO}.

@abhishekjiitr
Copy link
Contributor Author

@cclauss can you review?

cclauss
cclauss requested changes Oct 13, 2020
View reviewed changes
Copy link
Member

@cclauss cclauss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's match the changes made on lines 12, 14, 29, 30, and 34 of
https://github.com/TheAlgorithms/Python/blob/master/quantum/single_qubit_measure.py

@abhishekjiitr
Copy link
Contributor Author

@cclauss thanks for reminding. I overlooked the changes you finally added before merging.
The new commit adds changes requested similar to the one in the previous code.

@abhishekjiitr abhishekjiitr requested a review from cclauss October 13, 2020 16:18
@abhishekjiitr abhishekjiitr force-pushed the quantum-qiskit branch 2 times, most recently from 993609d to 26db5e6 Compare October 13, 2020 16:32
@abhishekjiitr
Address Review Comments
78c281b 
Signed-off-by: Abhishek Jaisingh <[email protected]>
cclauss
cclauss approved these changes Oct 13, 2020
View reviewed changes
Copy link
Member

@cclauss cclauss left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK.. Let's land this one even though it looks like a how-to-use example rather than a real algorithmic function. The two files we have so far do not help the reader to understand how quantum is better than conventional computing. So far, they are just data goes in and data comes out kind of functions with no story about what the data is and how the answer that comes out 1. makes the world a better place, and 2. is obtained faster or with more accuracy than with conventional computers.

@cclauss cclauss merged commit ca2d269 into TheAlgorithms:master Oct 13, 2020
@TravisBuddy
Copy link

Hey @abhishekjiitr,
Something went wrong with the build.

TravisCI finished with status errored, which means the build failed because of something unrelated to the tests, such as a problem with a dependency or the build process itself.

View build log

TravisBuddy Request Identifier: 204a38a0-0d72-11eb-9111-f326d0cb7f09

@dhruvmanila
Copy link
Member

dhruvmanila commented Oct 13, 2020 •
edited
Loading

@cclauss Um, is there any reason why you are merging failed commits?

@cclauss
Copy link
Member

cclauss commented Oct 13, 2020

The commit failed because we autodelete branches once they are merged. This means that the branch may already be gone before Travis and GH Actions have the time to clone them in.

@cclauss
Copy link
Member

cclauss commented Oct 13, 2020

Ooops... Now I see the problem. Sorry for moving too quickly.

stokhos pushed a commit to stokhos/Python that referenced this pull request Jan 3, 2021
@abhishekjiitr @stokhos
Add Qiskit Quantum NOT Gate Example Code (TheAlgorithms#3255)
97a8451 
* Add Qiskit Quantum NOT Gate Example Code

* Address Review Comments

Signed-off-by: Abhishek Jaisingh <[email protected]>
Panquesito7 pushed a commit to Panquesito7/Python that referenced this pull request May 13, 2021
@abhishekjiitr
Add Qiskit Quantum NOT Gate Example Code (TheAlgorithms#3255)
5366d52 
* Add Qiskit Quantum NOT Gate Example Code

* Address Review Comments

Signed-off-by: Abhishek Jaisingh <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cclauss cclauss cclauss approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@abhishekjiitr @TravisBuddy @dhruvmanila @cclauss